Skip to content

Port of #7652: contour flange options on the surfaces-first sheet model - #24

Draft
raykholo wants to merge 2 commits into
h0witzer:fix-6748-developfrom
raykholo:port/7652-contour-flange-options
Draft

raykholo wants to merge 2 commits into
h0witzer:fix-6748-developfrom
raykholo:port/7652-contour-flange-options

Conversation

@raykholo

Copy link
Copy Markdown

Port of tangency-labs#7652 (contour flange options, by @plexi32) onto the surfaces-first develop in tangency-labs#9245.

What it does

Changes from the original

  • The original drove the flat-to-3D bridge, which Sheet metal: one model, the part's surfaces; the flat pattern is derived (#6748) tangency-labs/solidcraft#9245 removes. The options now feed the surfaces directly (cfe406d, authored by Frank).
  • New (7eaaee3): a sharp corner beside an arc used to stop with "not supported yet". It now meets where the shifted line and shifted circle (or two shifted circles) cross, and the arc takes a new start and sweep. Closed-form unit tests cover line/arc and arc/arc corners.
  • The engine test for that profile pins the base's current refusal ("a bend on the edge of a roll") at all three orientations. Rolls are outside this PR.

Tests (buildq)

  • engine contour_flange: 10 passed
  • engine schema::sheet: 14 passed
  • doc sharp-corner unit tests: 2 passed
  • ui-egui contour_flange: 1 passed

Credit: @plexi32 (Frank) for the feature and the original PR.

plexi32 and others added 2 commits November 15, 2026 03:27
…e cross

The contour flange's orientation shifts the profile off its drawn
line. A sharp corner beside an arc used to stop with "not supported
yet"; it now meets where the shifted line and the shifted circle (or
two shifted circles) cross, and the arc takes a new start and sweep.

cfe406d carries the adaptation of tangency-labs#7652 onto the surfaces-first
develop (depth from orientation, offset_profile). This commit adds
the sharp-corner case on top, with unit tests for line/arc and
arc/arc corners.

The engine test now pins what the base still refuses at every
orientation ("a bend on the edge of a roll") for that profile.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants