Repository navigation
Conversation
…e cross The contour flange's orientation shifts the profile off its drawn line. A sharp corner beside an arc used to stop with "not supported yet"; it now meets where the shifted line and the shifted circle (or two shifted circles) cross, and the arc takes a new start and sweep. cfe406d carries the adaptation of tangency-labs#7652 onto the surfaces-first develop (depth from orientation, offset_profile). This commit adds the sharp-corner case on top, with unit tests for line/arc and arc/arc corners. The engine test now pins what the base still refuses at every orientation ("a bend on the edge of a roll") for that profile.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Port of tangency-labs#7652 (contour flange options, by @plexi32) onto the surfaces-first develop in tangency-labs#9245.
What it does
SurfaceSheet::contour: side 1 = 0, center = t/2, side 2 = t, withoffset_profileshifting the sketch.reversestill works when no orientation is set.Changes from the original
Tests (buildq)
contour_flange: 10 passedschema::sheet: 14 passedcontour_flange: 1 passedCredit: @plexi32 (Frank) for the feature and the original PR.