Repository navigation
fix(setup): MCP servers launch with only their own key from fnox, not Doppler - #84
Merged
Merged
Conversation
… Doppler Setup now registers each MCP server through bin/mcp-fnox-inject when fnox can decrypt that server's key, and through mcp-env-inject with the env file otherwise; Doppler no longer launches any server. The helper asks fnox for one key, from HOME (a repository's fnox.toml is never read), exports it alone and execs the server: `fnox exec` would hand every server every secret fnox holds. A key fnox cannot decrypt stops the server with a message, and exec keeps one process, so Claude's signals reach the server. The backend is decided per server, by its own key, so a machine with Brave in fnox and Tavily only in the env file gets each right. opencode's entries follow. @brave/brave-search-mcp-server is pinned to 2.1.4, as tavily was. mcp-key-rotate and the PowerShell setup keep Doppler for now (#85). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_014j4P2qfZbMTXBNFRaZdyiY
gutyoh
force-pushed
the
fix/mcp-backend-fnox
branch
from
November 15, 2026 20:38
30563b3 to
d23111d
Compare
The helper swallowed fnox's stderr, so a missing age key looked the same as a missing secret. The docs also say that keys already exported in Claude Code's own environment still reach every server. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_014j4P2qfZbMTXBNFRaZdyiY
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Doppler launched the brave-search and tavily MCP servers. The keys already live in fnox (age, fleet
secrets/fnox.toml), Doppler isn't installed on the devbox or the rig, and the owner stopped using it.Review of the first version caught a scope problem:
fnox exechas no per-key selector, so it hands every server every secret fnox holds. A compromised release of anpxserver would take them all. This version passes each server only its own key.What changes
bin/mcp-fnox-inject(new, symlinked bysetup.shlikemcp-env-inject):fnox.tomlis never read.execs the server: one process, so Claude's signals reach it and no orphan is left.lib/setup/mcp.sh:detect_mcp_backend <key>decides per server, by that server's own key.mcp-fnox-inject <VAR> npx -y <package>.check_mcp_env_varsreports per server.lib/setup/opencode.sh: same backend and entry, per server.@brave/brave-search-mcp-serveris pinned to2.1.4(bash, PowerShell registry, docs), as tavily already was.how-to-add-mcp-server.mdandarchitecture.md.Follow-up: #85 moves
mcp-key-rotateand the PowerShell setup off Doppler.Evidence
mcp-fnox-inject: 5/5 (only its key, asked for from HOME and never withexec; undecryptable and empty keys refused; the server replaces the helper's PID; bad input refused);just lintandjust format-check: clean. shellcheck on the helper and its tests: clean.initializethrough the helper, with no TTY or Keychain.BRAVE_API_KEYis set; the other fnox secrets (Tavily, Firecrawl, pools, ntfy) are absent.claude mcp listshows both ✔ Connected.🤖 Generated with Claude Code
https://claude.ai/code/session_014j4P2qfZbMTXBNFRaZdyiY