Repository navigation
ci: take the template's fixes from its latest version - #114
Conversation
Compared with codenhub/template at e7f1e72, core and node-pnpm profile, hunk by hunk. Taken: concurrency grouped by commit for push and merge-queue runs, so a third push to main no longer cancels the pending second; the corrected minimumReleaseAge description; the saved-state and read-enforced size-bound rules; and the document-roles section, with the index's "Start here" removed under it. Fixes #111 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 54 minutes. View limit details
No actionable comments were generated in the recent review. Walkthrough
Merge Risk:
|
There was a problem hiding this comment.
All reported issues were addressed across 6 files
Reply with feedback, questions, or to request a fix.
View guided diff | Turn on auto-fix | Re-trigger cubic
The document-roles rule bars leaf documents from telling the reader when to read another one, so the index's "Start with Architecture" and Architecture's "Read it before building" go. The size-bound rule said an input reaching the limit is rejected; it now says an input past the limit is, which matches the bookmark reader. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Summary
Compares Haku with codenhub/template at e7f1e72 (core and the
node-pnpmprofile), hunk by hunk, and takes the template's side where it is better:mainno longer cancels the pending second run. Pull request runs still cancel superseded ones.docs/ci.mdexplains the change and its cost: runs onmaincan now run in parallel.minimumReleaseAge:docs/ci.mdnow says pnpm only prefers versions older than a day, since the workspace does not set the option.Kept as Haku's: "report it privately" (Haku is public and uses private vulnerability reporting), the existing
formatscript, and the already-filled prompts.Fixes #111
Checks
The delivery gate
CONTRIBUTING.mdnames passes,pnpm verifyby default, or the skipped steps are listed hereDocumentation affected by behavior, API, or convention changes is updated in this pull request
docs/architecture.mdis updated if the architecture changed (not changed)src/bindings.tsis regenerated (pnpm bindings) if the IPC boundary changed (not changed)pnpm check:releasepasses iftauri/Cargo.tomlfeatures changed (not changed)A new IPC command, event, capability, or permission is named in the description and tested (none added)
Security
No code changes. The security guideline's size-bound rule is tightened. A follow-up issue may cover the existing unbounded reads of the settings file and extension manifests.
🤖 Generated with Claude Code
Summary by cubic
Applies the latest codenhub/template fixes to CI and documentation, addressing #111.
mainno longer cancels a pending run. Pull request runs still cancel superseded ones, and runs onmaincan now run in parallel.docs/ci.md:minimumReleaseAgeprefers versions older than a day but is not a hard gate, since the workspace does not set it.docs/README.mdanddocs/architecture.mddrop their routing lines.Written for commit 1ca29b6. Summary will update on new commits.
Summary by CodeRabbit