Conversation
max_transient_errors was never reset after a successful (non-terminal) poll, making it count errors across the whole wait instead of consecutive failures as documented. Introduces a trait for endpoints to declare their status field location via JSON Pointer, allowing generic wait operations without explicit pointer arguments. Includes a convenience function wait_for_status_typed that wraps wait_for_status but resolves the pointer from the endpoint's trait implementation. Assisted-By: Claude Sonnet 5 <noreply@anthropic.com> Signed-off-by: Artem Goncharov <artem.goncharov@gmail.com>
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
max_transient_errors was never reset after a successful (non-terminal)
poll, making it count errors across the whole wait instead of
consecutive failures as documented.
Introduces a trait for endpoints to declare their status field location
via JSON Pointer, allowing generic wait operations without explicit
pointer arguments. Includes a convenience function wait_for_status_typed
that wraps wait_for_status but resolves the pointer from the endpoint's
trait implementation.