Per-domain SMTP gateway tab in the domain details - #20
Open
gott-alexander wants to merge 3 commits into
Open
Conversation
Adds a new 'SMTP gateway' tab to the domain details view that lets
admins configure the per-domain outbound SMTP server (smart-host)
without leaving the web UI.
Changes:
* `src/containers/SmtpGateway.tsx` — new component that renders
the form (host, port, encryption, username, password, from
address, description) and uses the `useAPI` hook to talk to
the new REST endpoint mounted by grommunio-admin-api. Password
field is masked and only sent on save when populated.
* `src/containers/DomainDetails.tsx` — fourth tab is rendered
conditionally and a ref-based handle lets the parent page
invoke `saveSmtpGateway` from the toolbar Save button, so the
existing save flow keeps working.
Companion changes: grommunio/gromox#<PR> and
grommunio/admin-api#<PR>.
from_address is no longer consumed anywhere (smart-host routing is handled by the MTA); the form field had no effect.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a new 'SMTP gateway' tab to the domain details view that lets admins configure the per-domain outbound SMTP server (smart-host) without leaving the web UI.
Changes:
src/containers/SmtpGateway.tsx— new component that renders the form (host, port, encryption, username, password, from address, description) and uses theuseAPIhook to talk to the new REST endpoint mounted by grommunio-admin-api. Password field is masked and only sent on save when populated.src/containers/DomainDetails.tsx— fourth tab is rendered conditionally and a ref-based handle lets the parent page invokesaveSmtpGatewayfrom the toolbar Save button, so the existing save flow keeps working.Companion changes: grommunio/gromox# and
grommunio/admin-api#.
This involves several repositories. It's probably not bug-free. It still needs testing and others to continue working on it, since I don't have the time.
It's already possible to send an email via the web interface using the SMTP gateway in the background (most of the time).