Skip to content

Refactor so that it uses aptiko.general v1 - #8

Merged
aptiko merged 2 commits into
masterfrom
wrk-112--aptiko-general-v1
Jul 20, 2026
Merged

Refactor so that it uses aptiko.general v1#8
aptiko merged 2 commits into
masterfrom
wrk-112--aptiko-general-v1

Conversation

@aptiko

@aptiko aptiko commented Jul 20, 2026

Copy link
Copy Markdown
Collaborator

No description provided.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Refactors the GRNET Nextcloud/Jitsi Ansible collection and accompanying documentation to align with aptiko.general v1, including the new base, webserver, and website roles and a shift from ferm-managed rules to nftables snippets where applicable.

Changes:

  • Update documentation playbook snippets to use aptiko.general.base and aptiko.general.webserver with webserver_type.
  • Replace aptiko.general.nginx_site / aptiko.general.apache_vhost role dependencies with aptiko.general.website.
  • Migrate firewall rule injection from /etc/ferm/ansible-late to /etc/nftables/ansible-late.nft and rename coturn-related defaults/variables accordingly.

Reviewed changes

Copilot reviewed 18 out of 18 changed files in this pull request and generated 6 comments.

Show a summary per file
File Description
docs/nextcloud/talk_recording.rst Updates example roles to aptiko.general.base + aptiko.general.webserver.
docs/nextcloud/talk_hpb.rst Updates example roles to aptiko.general.base + aptiko.general.webserver.
docs/nextcloud/nextcloud.rst Updates usage example and documents switch to aptiko.general.website.
docs/nextcloud/guide_nextcloud.rst Removes ferm-specific rationale section.
docs/nextcloud/coturn.rst Renames/extends coturn variables and references aptiko.general.base firewall behavior.
docs/jitsi/guide.rst Updates example playbooks to aptiko.general.base + aptiko.general.webserver.
ansible-collections/grnet/nextcloud/roles/talk_recording/meta/main.yml Switches dependency from nginx_site to aptiko.general.website.
ansible-collections/grnet/nextcloud/roles/talk_hpb/meta/main.yml Switches dependencies to aptiko.general.website.
ansible-collections/grnet/nextcloud/roles/nextcloud/meta/main.yml Switches web vhost dependencies to aptiko.general.website.
ansible-collections/grnet/nextcloud/roles/coturn/tasks/main.yml Migrates firewall rules to nftables and renames letsencrypt/firewall toggles.
ansible-collections/grnet/nextcloud/roles/coturn/defaults/main.yml Updates default variable names for firewall and letsencrypt setup.
ansible-collections/grnet/nextcloud/roles/collabora/meta/main.yml Switches dependencies to aptiko.general.website.
ansible-collections/grnet/nextcloud/examples/nextcloud-deploy/site.yml Updates example deploy play to use aptiko.general.base + aptiko.general.webserver.
ansible-collections/grnet/jitsi/roles/jitsi_meet/tasks/prosody.yml Uses FQCN modules and migrates firewall rule injection to nftables.
ansible-collections/grnet/jitsi/roles/jitsi_meet/requirements.yml Removes legacy role requirements file.
ansible-collections/grnet/jitsi/roles/jitsi_meet/meta/main.yml Switches dependency from nginx_site to aptiko.general.website (keeps node + excalidraw deps).
ansible-collections/grnet/jitsi/roles/jitsi_jvb/tasks/main.yml Uses FQCN modules, file modes, and migrates firewall rules to nftables.
ansible-collections/grnet/jitsi/roles/jibri/meta/main.yml Switches dependency from nginx_site to aptiko.general.website.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread docs/nextcloud/talk_hpb.rst
Comment thread docs/jitsi/guide.rst
Comment thread docs/nextcloud/nextcloud.rst Outdated
Comment thread docs/nextcloud/nextcloud.rst Outdated
Comment thread ansible-collections/grnet/jitsi/roles/jitsi_jvb/tasks/main.yml Outdated
Comment thread ansible-collections/grnet/nextcloud/roles/coturn/tasks/main.yml
@aptiko
aptiko force-pushed the wrk-112--aptiko-general-v1 branch from a35c046 to 668059c Compare July 20, 2026 10:18
@aptiko
aptiko requested a review from Copilot July 20, 2026 10:18

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 19 out of 19 changed files in this pull request and generated 4 comments.

Comments suppressed due to low confidence (1)

docs/jitsi/guide.rst:131

  • In this guide, the other plays include aptiko.general.base before configuring the webserver. The Jibri play currently omits it, which makes the example inconsistent and may miss base setup expected by the collection (e.g., firewall/cert tooling).
      roles:
        - role: aptiko.general.webserver
          webserver_type: nginx  # Only nginx is supported
        - grnet.jitsi.jibri

Comment thread docs/nextcloud/nextcloud.rst Outdated
Comment thread docs/nextcloud/coturn.rst
Comment thread ansible-collections/grnet/nextcloud/examples/nextcloud-deploy/site.yml Outdated
@aptiko
aptiko force-pushed the wrk-112--aptiko-general-v1 branch from 668059c to ddf8f8c Compare July 20, 2026 10:47
@aptiko
aptiko requested a review from Copilot July 20, 2026 10:47

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 20 out of 20 changed files in this pull request and generated 1 comment.

@aptiko
aptiko force-pushed the wrk-112--aptiko-general-v1 branch from ddf8f8c to 3f08596 Compare July 20, 2026 11:01
@aptiko
aptiko requested a review from Copilot July 20, 2026 11:01

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 20 out of 20 changed files in this pull request and generated 2 comments.

Comments suppressed due to low confidence (1)

docs/jitsi/guide.rst:130

  • The Jibri playbook example includes aptiko.general.webserver but omits aptiko.general.base, while the earlier Jitsi server/videobridge examples include it. If aptiko.general.base is required for baseline host setup (e.g., firewall defaults), this example will be inconsistent and may fail or behave differently than the rest of the guide.
      roles:
        - role: aptiko.general.webserver
          webserver_type: nginx  # Only nginx is supported

Comment thread docs/nextcloud/coturn.rst
Comment thread ansible-collections/grnet/nextcloud/roles/coturn/tasks/main.yml
@aptiko
aptiko merged commit 3f08596 into master Jul 20, 2026
1 check passed
@aptiko
aptiko deleted the wrk-112--aptiko-general-v1 branch July 20, 2026 11:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants