Refactor so that it uses aptiko.general v1 - #8
Conversation
There was a problem hiding this comment.
Pull request overview
Refactors the GRNET Nextcloud/Jitsi Ansible collection and accompanying documentation to align with aptiko.general v1, including the new base, webserver, and website roles and a shift from ferm-managed rules to nftables snippets where applicable.
Changes:
- Update documentation playbook snippets to use
aptiko.general.baseandaptiko.general.webserverwithwebserver_type. - Replace
aptiko.general.nginx_site/aptiko.general.apache_vhostrole dependencies withaptiko.general.website. - Migrate firewall rule injection from
/etc/ferm/ansible-lateto/etc/nftables/ansible-late.nftand rename coturn-related defaults/variables accordingly.
Reviewed changes
Copilot reviewed 18 out of 18 changed files in this pull request and generated 6 comments.
Show a summary per file
| File | Description |
|---|---|
| docs/nextcloud/talk_recording.rst | Updates example roles to aptiko.general.base + aptiko.general.webserver. |
| docs/nextcloud/talk_hpb.rst | Updates example roles to aptiko.general.base + aptiko.general.webserver. |
| docs/nextcloud/nextcloud.rst | Updates usage example and documents switch to aptiko.general.website. |
| docs/nextcloud/guide_nextcloud.rst | Removes ferm-specific rationale section. |
| docs/nextcloud/coturn.rst | Renames/extends coturn variables and references aptiko.general.base firewall behavior. |
| docs/jitsi/guide.rst | Updates example playbooks to aptiko.general.base + aptiko.general.webserver. |
| ansible-collections/grnet/nextcloud/roles/talk_recording/meta/main.yml | Switches dependency from nginx_site to aptiko.general.website. |
| ansible-collections/grnet/nextcloud/roles/talk_hpb/meta/main.yml | Switches dependencies to aptiko.general.website. |
| ansible-collections/grnet/nextcloud/roles/nextcloud/meta/main.yml | Switches web vhost dependencies to aptiko.general.website. |
| ansible-collections/grnet/nextcloud/roles/coturn/tasks/main.yml | Migrates firewall rules to nftables and renames letsencrypt/firewall toggles. |
| ansible-collections/grnet/nextcloud/roles/coturn/defaults/main.yml | Updates default variable names for firewall and letsencrypt setup. |
| ansible-collections/grnet/nextcloud/roles/collabora/meta/main.yml | Switches dependencies to aptiko.general.website. |
| ansible-collections/grnet/nextcloud/examples/nextcloud-deploy/site.yml | Updates example deploy play to use aptiko.general.base + aptiko.general.webserver. |
| ansible-collections/grnet/jitsi/roles/jitsi_meet/tasks/prosody.yml | Uses FQCN modules and migrates firewall rule injection to nftables. |
| ansible-collections/grnet/jitsi/roles/jitsi_meet/requirements.yml | Removes legacy role requirements file. |
| ansible-collections/grnet/jitsi/roles/jitsi_meet/meta/main.yml | Switches dependency from nginx_site to aptiko.general.website (keeps node + excalidraw deps). |
| ansible-collections/grnet/jitsi/roles/jitsi_jvb/tasks/main.yml | Uses FQCN modules, file modes, and migrates firewall rules to nftables. |
| ansible-collections/grnet/jitsi/roles/jibri/meta/main.yml | Switches dependency from nginx_site to aptiko.general.website. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
a35c046 to
668059c
Compare
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 19 out of 19 changed files in this pull request and generated 4 comments.
Comments suppressed due to low confidence (1)
docs/jitsi/guide.rst:131
- In this guide, the other plays include
aptiko.general.basebefore configuring the webserver. The Jibri play currently omits it, which makes the example inconsistent and may miss base setup expected by the collection (e.g., firewall/cert tooling).
roles:
- role: aptiko.general.webserver
webserver_type: nginx # Only nginx is supported
- grnet.jitsi.jibri
668059c to
ddf8f8c
Compare
ddf8f8c to
3f08596
Compare
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 20 out of 20 changed files in this pull request and generated 2 comments.
Comments suppressed due to low confidence (1)
docs/jitsi/guide.rst:130
- The Jibri playbook example includes
aptiko.general.webserverbut omitsaptiko.general.base, while the earlier Jitsi server/videobridge examples include it. Ifaptiko.general.baseis required for baseline host setup (e.g., firewall defaults), this example will be inconsistent and may fail or behave differently than the rest of the guide.
roles:
- role: aptiko.general.webserver
webserver_type: nginx # Only nginx is supported
No description provided.