test(gax): add timeout integration tests for GrpcRustClient - #6480
Draft
joshuatants wants to merge 1 commit into
Draft
test(gax): add timeout integration tests for GrpcRustClient#6480joshuatants wants to merge 1 commit into
joshuatants wants to merge 1 commit into
Conversation
For googleapis#5991. Mirrors tests from `src/gax-internal/tests/grpc_timeout.rs`: - `no_timeout` - `timeout_does_not_expire` - `timeout_expires` - `client_config_timeout` (adapted from `test_effective_timeout`)
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request adds a new integration test file grpc_rust_timeout.rs under src/gax-internal/tests/ to verify gRPC timeout behaviors using the GrpcRustClient. The tests cover scenarios including requests with no timeout, timeouts that do not expire, timeouts that do expire, and timeouts configured via the client configuration. I have no feedback to provide.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## grpc_rust #6480 +/- ##
==========================================
Coverage 96.39% 96.39%
==========================================
Files 302 302
Lines 85747 85747
==========================================
+ Hits 82656 82659 +3
+ Misses 3091 3088 -3 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For #5991.
Mirrors tests from
src/gax-internal/tests/grpc_timeout.rs:no_timeouttimeout_does_not_expiretimeout_expiresclient_config_timeout(adapted fromtest_effective_timeout)