Skip to content

test(bigquery): add integration tests for pending stream - #6478

Merged
haphungw merged 5 commits into
googleapis:mainfrom
haphungw:bq-write-pending-streams-test-refactor
Aug 20, 2026
Merged

test(bigquery): add integration tests for pending stream#6478
haphungw merged 5 commits into
googleapis:mainfrom
haphungw:bq-write-pending-streams-test-refactor

Conversation

@haphungw

Copy link
Copy Markdown
Contributor

Add integration tests for the Pending write streams introduced in #6474.
Refactor the test suites for bigquery write.

For #6402

@product-auto-label product-auto-label Bot added the api: bigquery Issues related to the BigQuery API. label Aug 20, 2026

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request refactors the BigQuery write tests by introducing a dedicated WriteUserRecord struct and helper functions to set up and verify write operations. It updates the basic write test to use these helpers and adds a new pending write test to verify pending stream writes. The feedback identifies a redundant import in tests/bigquery/src/writes/arrow.rs that can be removed since the items are already imported via use super::*;.

Comment thread tests/bigquery/src/writes/arrow.rs
@codecov

codecov Bot commented Aug 20, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 96.37%. Comparing base (18ffab7) to head (0ce67f2).
⚠️ Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6478   +/-   ##
=======================================
  Coverage   96.37%   96.37%           
=======================================
  Files         297      297           
  Lines       84017    84017           
=======================================
+ Hits        80971    80973    +2     
+ Misses       3046     3044    -2     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@haphungw
haphungw force-pushed the bq-write-pending-streams-test-refactor branch from 5961264 to a401770 Compare August 20, 2026 00:45
Comment thread tests/bigquery/src/table.rs Outdated
Comment thread tests/bigquery/src/writes/arrow.rs
Comment thread tests/bigquery/src/writes.rs Outdated
Comment thread tests/bigquery/src/writes.rs Outdated
Comment thread tests/bigquery/src/writes.rs Outdated
Comment thread tests/bigquery/src/writes.rs Outdated
Comment thread tests/bigquery/src/writes/arrow.rs Outdated
@haphungw
haphungw marked this pull request as ready for review August 20, 2026 18:01
@haphungw
haphungw requested a review from a team as a code owner August 20, 2026 18:01
Comment thread tests/bigquery/src/writes/arrow.rs Outdated
Comment thread tests/bigquery/src/writes/arrow.rs Outdated
Comment thread tests/bigquery/src/writes/arrow.rs
@haphungw
haphungw enabled auto-merge (squash) August 20, 2026 18:38
@haphungw
haphungw merged commit 941f392 into googleapis:main Aug 20, 2026
42 checks passed
@haphungw
haphungw deleted the bq-write-pending-streams-test-refactor branch August 20, 2026 18:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: bigquery Issues related to the BigQuery API.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants