test(bigquery): add integration tests for pending stream - #6478
Merged
haphungw merged 5 commits intoAug 20, 2026
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request refactors the BigQuery write tests by introducing a dedicated WriteUserRecord struct and helper functions to set up and verify write operations. It updates the basic write test to use these helpers and adds a new pending write test to verify pending stream writes. The feedback identifies a redundant import in tests/bigquery/src/writes/arrow.rs that can be removed since the items are already imported via use super::*;.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #6478 +/- ##
=======================================
Coverage 96.37% 96.37%
=======================================
Files 297 297
Lines 84017 84017
=======================================
+ Hits 80971 80973 +2
+ Misses 3046 3044 -2 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
haphungw
force-pushed
the
bq-write-pending-streams-test-refactor
branch
from
August 20, 2026 00:45
5961264 to
a401770
Compare
dbolduc
approved these changes
Aug 20, 2026
dbolduc
approved these changes
Aug 20, 2026
haphungw
marked this pull request as ready for review
August 20, 2026 18:01
dbolduc
approved these changes
Aug 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add integration tests for the
Pendingwrite streams introduced in #6474.Refactor the test suites for
bigquery write.For #6402