Skip to content

impl(librarian.yaml): add streaming package dependencies config - #6476

Merged
suzmue merged 3 commits into
googleapis:mainfrom
suzmue:streaming-deps
Aug 20, 2026
Merged

impl(librarian.yaml): add streaming package dependencies config#6476
suzmue merged 3 commits into
googleapis:mainfrom
suzmue:streaming-deps

Conversation

@suzmue

@suzmue suzmue commented Aug 19, 2026

Copy link
Copy Markdown
Contributor

Add streaming deps to default rust package dependencies with used_if: streaming in librarian.yaml. This also cleans up the necessary dependencies after refactoring.

Regenerate google-cloud-showcase-v1beta1 to use the dynamic streaming dependencies.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the dependency configuration in librarian.yaml to conditionally include streaming-related crates (futures, http, prost, prost-types, tokio, and tokio-stream) when streaming is enabled. It also updates the generated Cargo.toml and model.rs for the showcase crate to reflect these dependencies and ensure they are sorted alphabetically. I have no feedback to provide.

@suzmue suzmue changed the title feat(librarian): add streaming package dependencies impl(librarian.yaml): add streaming package dependencies Aug 19, 2026
suzmue added 2 commits August 20, 2026 17:15
Add prost and prost-types to default rust package dependencies with
used_if: streaming in librarian.yaml.

Regenerate google-cloud-showcase-v1beta1 to use the dynamic streaming
dependencies.
@suzmue
suzmue marked this pull request as ready for review August 20, 2026 17:23
@suzmue
suzmue requested review from a team as code owners August 20, 2026 17:23
@suzmue suzmue changed the title impl(librarian.yaml): add streaming package dependencies impl(librarian.yaml): add streaming package dependencies config Aug 20, 2026
@codecov

codecov Bot commented Aug 20, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 96.39%. Comparing base (fa829ec) to head (c98de1a).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6476   +/-   ##
=======================================
  Coverage   96.38%   96.39%           
=======================================
  Files         298      298           
  Lines       84328    84328           
=======================================
+ Hits        81280    81284    +4     
+ Misses       3048     3044    -4     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@suzmue
suzmue merged commit 90d13cb into googleapis:main Aug 20, 2026
42 checks passed
@suzmue
suzmue deleted the streaming-deps branch August 20, 2026 18:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants