Skip to content

feat(gax-internal): re-export Client and ClientBuilder in http::reqwest - #6446

Merged
olavloite merged 4 commits into
googleapis:mainfrom
olavloite:gax-internal-export-reqwest-client
Aug 21, 2026
Merged

feat(gax-internal): re-export Client and ClientBuilder in http::reqwest#6446
olavloite merged 4 commits into
googleapis:mainfrom
olavloite:gax-internal-export-reqwest-client

Conversation

@olavloite

@olavloite olavloite commented Aug 18, 2026

Copy link
Copy Markdown
Contributor

Re-export reqwest::Client and reqwest::ClientBuilder from gaxi::http::reqwest. It does not bump the gax-internal version number, as that version has already been updated for the next release by other pull requests.

This allows client libraries to construct HTTP clients with custom connection timeouts (such as for querying the Compute Engine Metadata Service) without declaring direct dependencies on reqwest.

Needed for #6445

@olavloite
olavloite requested a review from a team as a code owner August 18, 2026 16:48

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request bumps the version of the google-cloud-gax-internal crate (and its dependency reference gaxi) from 0.7.18 to 0.7.19. Additionally, it re-exports Client and ClientBuilder from the reqwest module in src/gax-internal/src/http/reqwest.rs. There are no review comments, and I have no feedback to provide.

@codecov

codecov Bot commented Aug 18, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 96.37%. Comparing base (9ed9339) to head (60d9868).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6446   +/-   ##
=======================================
  Coverage   96.37%   96.37%           
=======================================
  Files         297      297           
  Lines       84017    84017           
=======================================
  Hits        80971    80971           
  Misses       3046     3046           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Re-export `reqwest::Client` and `reqwest::ClientBuilder` from `gaxi::http::reqwest` and bump `google-cloud-gax-internal` to `0.7.19`.

This allows client libraries to construct HTTP clients with custom connection timeouts (such as for querying the Compute Engine Metadata Service) without declaring direct dependencies on `reqwest`.
@olavloite
olavloite force-pushed the gax-internal-export-reqwest-client branch from a35061f to 990ab00 Compare August 19, 2026 05:24
@olavloite
olavloite requested a review from a team as a code owner August 19, 2026 05:24

@coryan coryan left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please revert the bumps:

git describe --tags --abbrev=0 upstream/main
git diff release-20260730 -- src/gax-internal/Cargo.toml

Comment thread src/gax-internal/Cargo.toml Outdated
[package]
name = "google-cloud-gax-internal"
version = "0.7.18"
version = "0.7.19"

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't need to bump this again, it was already bumped (twice) since the last release.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@olavloite
olavloite requested a review from coryan August 20, 2026 05:23
@olavloite
olavloite merged commit 2d071f2 into googleapis:main Aug 21, 2026
42 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants