Refactor UpdateMaxCapacities and ResizeSlabs to initialize CPU slabs before stopping all CPUs. - #603
Draft
copybara-service[bot] wants to merge 1 commit into
Draft
Refactor UpdateMaxCapacities and ResizeSlabs to initialize CPU slabs before stopping all CPUs.#603copybara-service[bot] wants to merge 1 commit into
copybara-service[bot] wants to merge 1 commit into
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
copybara-service
Bot
force-pushed
the
test_973865650
branch
3 times, most recently
from
August 31, 2026 18:11
0788a63 to
aa1044d
Compare
copybara-service
Bot
changed the title
copybara-service
Bot
force-pushed
the
test_973865650
branch
2 times, most recently
from
August 31, 2026 20:19
ca18624 to
d139512
Compare
…before stopping all CPUs. This avoids page faulting in the newly allocated slabs while CPUs are stopped. Since updating capacities still needs to happen while CPUs are stopped, the capacity callback needs to return the new capacities rather than the current ones. This way initializing the CPU slabs can happen before update_capacity is called. PiperOrigin-RevId: 973865650
copybara-service
Bot
force-pushed
the
test_973865650
branch
from
September 1, 2026 14:03
d139512 to
b92cd4e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactor UpdateMaxCapacities and ResizeSlabs to initialize CPU slabs before stopping all CPUs.
This avoids page faulting in the newly allocated slabs while CPUs are stopped. Since updating capacities still needs to happen while CPUs are stopped, the capacity callback needs to return the new capacities rather than the current ones. This way initializing the CPU slabs can happen before update_capacity is called.