docs: connect MergeLeafTypes to multi-typed entities / array @type#223
Open
1chooo wants to merge 1 commit into
Open
docs: connect MergeLeafTypes to multi-typed entities / array @type#2231chooo wants to merge 1 commit into
1chooo wants to merge 1 commit into
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
Clarify the "Merging multiple concrete types" README section so it names the common use cases it solves: multi-typed entities and an array-valued `@type` such as ['Product', 'SoftwareApplication']. Helps users searching for the requests in google#179 and google#189 find the existing MergeLeafTypes helper.
1chooo
force-pushed
the
docs/mergeleaftypes-mte
branch
from
9434ff9 to
6d768dd
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The "Merging multiple concrete types" README section documents
MergeLeafTypesbut never names the use cases people actually search for: multi-typed entities
and an array-valued
@typesuch as['Product', 'SoftwareApplication']. Thisadds a short lead-in so those users find the existing helper.
Relates to #179 and #189.
Changes
Test plan
packages/schema-dts/test/mergeleaftypes.tsalready covers behavior.I have signed / will sign the Google CLA per CONTRIBUTING.md.
Made with Cursor