Skip to content

Remove platform and architecture detection logic - #383

Open
kleisauke wants to merge 2 commits into
google:mainfrom
kleisauke:remove-platform-arch-detect
Open

Remove platform and architecture detection logic#383
kleisauke wants to merge 2 commits into
google:mainfrom
kleisauke:remove-platform-arch-detect

Conversation

@kleisauke

Copy link
Copy Markdown

Also drop arch-specific compile and optimization flags to ensure packaging friendliness.

Context: #376.

Also drop arch-specific compile and optimization flags to ensure
packaging friendliness.
@gregbenz

Copy link
Copy Markdown
Contributor

Improving cross-platform builds is a great direction.

On Apple Silicon, setting CMAKE_OSX_ARCHITECTURES=x86_64 can leave CMAKE_SYSTEM_PROCESSOR=arm64, so the new condition selects ARM sources for an Intel build. A small CMake probe using that condition fails on arm_neon.h.

Could the NEON source selection also account for CMAKE_OSX_ARCHITECTURES, while still letting the toolchain choose the architecture flags?

@kleisauke

Copy link
Copy Markdown
Author

@gregbenz Fixed with commit 7af3588. Thanks for your review!

@gregbenz

Copy link
Copy Markdown
Contributor

@kleisauke Thanks, looks good!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants