icc: update tone mapping - #340
Open
ram-mohan wants to merge 1 commit into
Open
Conversation
ram-mohan
force-pushed
the
icc
branch
2 times, most recently
from
December 24, 2024 05:44
6ea32f9 to
3c25f80
Compare
ram-mohan
force-pushed
the
icc
branch
2 times, most recently
from
February 18, 2025 10:39
39c2bce to
b1c1e38
Compare
- update tone mapping to reflect the implementation in api-0. - update the icc profile to output results in xyz D50 instead of Lab. - update the icc profile to output tonemap results in api-0 only. - add chad tag. Test: ./ultrahdr_unit_test
Contributor
|
Aligning the ICC fallback with API-0 would improve consistency, but two details may need correction: PQ still declares Lab PCS although the new transform produces XYZ D50, and Evaluating the tone-mapping stage at peak white gives approximately 0.5002 for PQ and 0.5206 for HLG instead of 1.0, before ICC serialization. Could these be corrected and covered by PQ/HLG comparisons against API-0, including validation through an independent ICC consumer? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Test: ./ultrahdr_unit_test