Conversation
Member
Author
|
/gemini review |
Member
Author
|
Would you do a thorough check to make sure that the behavior will always match the behavior of the previous Objective-C implementation I've just done a deep line-by-line comparison of the new Swift components against the original 1. Concurrency and Deduplication (Perfect Match)
2. Provider Initialization (Perfect Match)
3. Edge Cases & Type Handling (Matched & Improved)
ConclusionOutside of the
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR migrates AppCheckCore from Objective-C to Swift, replacing FBLPromises with async/await while maintaining Objective-C backwards compatibility.
CocoaPods port is not intended for release - only to increase test coverage, since several tests are CocoaPods only.
See google/GoogleSignIn-iOS#626 and firebase/firebase-ios-sdk#16544 for integration testing with the AppCheckCore dependencies.
Architectural Changes & Code Review Summary
1. Code Conversion and Modernization
FBLPromiseand manualdispatch_queuecallback chains were successfully migrated to Swiftasync/await.@objcand@objcMembersannotations were attached to Swift classes. LegacyGAC...prefixes (e.g.,@objc(GACAppCheckSettings)) were properly maintained so that down-stream clients wouldn't encounter missing symbols.objc_subclassing_restrictedattribute, breaking existing Objective-C classes that historically subclassed them (e.g.FIRAppCheckSettings). This was resolved by removing direct subclassing and satisfying protocols (GACAppCheckSettingsProtocol) instead.2. File and Structural Integrity
.swiftfiles correctly apply the Apache 2.0 license headers.AppCheckCore.h) and public module headers have been safely retired or modified to point to theAppCheckCore-Swift.hbridge.3. API Signature Consistency
initWithToken:expirationDate:receivedAtDate:explicitly uses thereceivedAt:argument label in Swift to prevent breaking compilation across SDKs that depended on Swift's automatic Clang truncation.GACAppCheckErrorDomain) do not export easily, so usages have been cleaned up or replaced by their literal string representations.4. Build and Compilation Validation
AppCheckCoreframework compiles with 0 warnings and 0 errors locally.