Add button for adding device panel vertically into view panel - #2883
Open
k311093 wants to merge 1 commit into
Open
Add button for adding device panel vertically into view panel#2883k311093 wants to merge 1 commit into
k311093 wants to merge 1 commit into
Conversation
0405ysj
reviewed
Jul 23, 2026
0405ysj
reviewed
Jul 23, 2026
0405ysj
left a comment
0405ysj
left a comment
Collaborator
There was a problem hiding this comment.
I'm not certain if I'm the right person to review, as I don't have much experience on Angular.
k311093
force-pushed
the
vertical
branch
4 times, most recently
from
July 23, 2026 07:28
4f270eb to
ae32fd6
Compare
0405ysj
reviewed
Jul 23, 2026
k311093
force-pushed
the
vertical
branch
3 times, most recently
from
August 4, 2026 07:31
0d68a29 to
5f1397a
Compare
In the multiple device scanerio with landscape device screen, stacking device panel horizontally is not a good experience to use. (it need to scroll page right side to see the device). Add a toggle button to adding device panel vertically to support this case. b/534778982
0405ysj
approved these changes
Aug 5, 2026
| stackVertical = true; | ||
| } else { | ||
| stackVertical = | ||
| layout.length !== 0 && rightBorder + item.w > this.cols; |
Collaborator
There was a problem hiding this comment.
layout.length !== 0 is not necessary here, as there should be no diff whether stacking horizontal or vertical when no item exists. So I think we can shrink like:
stackVertical = this.displaysService.addVertically$.value && rightBorder + item.w > this.cols;
| const lastMaxY = | ||
| let stackVertical = false; | ||
| const lastItemY = | ||
| layout.length !== 0 ? Math.max(...layout.map(obj => obj.y)) : 0; |
Collaborator
There was a problem hiding this comment.
nit: const lastItemY = Math.max(...layout.map(obj => obj.y), 0);?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the multiple device scanerio with landscape device screen, stacking device panel horizontally is not a good experience to use. (it need to scroll page right side to see the device).
Add a toggle button to adding device panel vertically to support this case.
b/534778982