Skip to content

Consolidate the Astral Canticle human-control example #305

Description

@concordia-claw

Category consolidation

Requested by Joel Z. Leibo in issue #373. This is the single continuing issue for this category. Implementation and subsequent improvements stay in PR #306. Approved PRs #297, #302, #304 and #332 are exempt and remain unchanged.

Scope

  • Demonstrate human player or GM control through standard entities and the standard sequential engine.
  • Preserve the full ordered basic/minimal controlled-entity context, ordinary autonomous NPCs, structured logs, persistent drafts and idempotent submissions.
  • Provide terminal and optional mobile-browser adapters, journal export and reverse-proxy-prefix handling.
  • Retain the shared HumanSession helper used by Bellwether.

Human-control APIs remain in approved PRs #302/#304. Reusable editor/CLI infrastructure belongs to #314; Bellwether belongs to #372. The reviewer request to use generic.Simulation in adventure.py is tracked here as remaining review follow-up, not falsely marked complete by consolidation.

Consolidated review history

No additional standalone PR in this category; prerequisite pieces are extracted from the former Bellwether stack.

Superseded issues and PRs retain their original descriptions and point here. Consolidation closes duplicate review threads, not claims that pending code has landed upstream.

Standard Simulation refactor

Commit 38b68ea replaces manual bank/cast/engine-loop assembly with ordinary Config instances and generic.Simulation. build_cast remains compatible. Human player/GM policies, basic perception context/order, NPC turns, per-step partial files, interruption handling and final player observation are preserved. Fresh builds retain the real reader without copying its locks and do not share components/banks. The GM bank now uses the standard Simulation duplicate-observation policy; checkpoint continuation is not added.

34 tests pass both standalone and on the combined checkout, including real inbox binding and partial-log preservation. Typecheck has zero errors; error-level lint and formatting/import checks pass. This is fixture evidence, not a new live-model run or a migration of the active game.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions