Change CI to run on pull_request_target - #333
Open
trond-snekvik wants to merge 1 commit into
Open
Conversation
With the "Require approval for all external contributors" flag set for the repo, and the token permissions being set to `content: read` and `actions: write`, I believe this should be perfectly safe for us, and allows fork PRs to run CI - automatically for us and upon approval for external contributors. Signed-off-by: Trond Snekvik <trond.snekvik@canonical.com>
szczys
requested changes
Aug 31, 2026
| branches: | ||
| - main | ||
| pull_request: | ||
| pull_request_target: |
Contributor
There was a problem hiding this comment.
I don't think it is safe to use this trigger for all of the workflows that this kicks off. The build step for untrusted branches should run in an unprivileged job which I think is what pull_request accomplishes. Let's discuss this synchronously to hash through some of the downsides.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With the "Require approval for all external contributors" flag set for the repo, and the token permissions being set to
content: readandactions: write, I believe this should be perfectly safe for us, and allows fork PRs to run CI - automatically for us and upon approval for external contributors.