back: find the auxiliary files when GNUSTEP_MAKEFILES is unset#162
Open
DTW-Thalion wants to merge 1 commit into
Open
back: find the auxiliary files when GNUSTEP_MAKEFILES is unset#162DTW-Thalion wants to merge 1 commit into
DTW-Thalion wants to merge 1 commit into
Conversation
configure passed the GNUSTEP_MAKEFILES variable straight to AC_CONFIG_AUX_DIR, but the generated configure searches for config.guess and config.sub before the shell code that sets GNUSTEP_MAKEFILES from gnustep-config has run. With GNUSTEP_MAKEFILES unset in the environment configure then failed with "cannot find required auxiliary files". Resolve the makefiles directory inline in the AC_CONFIG_AUX_DIR argument, the way gnustep-base already does, so the auxiliary files are found whether or not GNUSTEP_MAKEFILES is set in the environment. The generated configure is updated to match.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #54.
configurepassed theGNUSTEP_MAKEFILESvariable straight toAC_CONFIG_AUX_DIR, but the generatedconfiguresearches forconfig.guessandconfig.subbefore the shell code that setsGNUSTEP_MAKEFILESfromgnustep-configruns. WithGNUSTEP_MAKEFILESunset in the environment,configurethen failed withcannot find required auxiliary files.Resolve the makefiles directory inline in the
AC_CONFIG_AUX_DIRargument, the way gnustep-base already does, so the auxiliary files are found whether or notGNUSTEP_MAKEFILESis set. The generatedconfigureis updated to match (rather than regenerated, since it was produced with a different autoconf version than is available here; the inline argument text matches gnustep-base's shippedconfigure).Verified: with
GNUSTEP_MAKEFILESunset, the currentconfigurefails with the auxiliary-files error, and with this change it completes and createsconfig.make. The normal case withGNUSTEP_MAKEFILESset is unaffected.