back/wayland: build the X11 pasteboard owner into gpbs#161
Open
DTW-Thalion wants to merge 1 commit into
Open
Conversation
gpbs selects XPbOwner as its pasteboard owner on every platform except Windows, but xpbs.m, which defines that class, was only compiled for the x11 server. A wayland build therefore produced a gpbs with no pasteboard owner, so NSPasteboard was disconnected from the desktop clipboard and paste was disabled in GNUstep applications. Compile xpbs.m and xdnd.c into gpbs for a wayland build when X11 is available, so the X11 owner reaches the desktop clipboard through XWayland. Guarding on X11 keeps a wayland build without X11 unchanged.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #71.
gpbsselectsXPbOwneras its pasteboard owner on every platform except Windows, butxpbs.m, which defines that class, was compiled only for the x11 server. A wayland build therefore produced agpbswith no pasteboard owner, soNSPasteboardwas disconnected from the desktop clipboard and paste was disabled in GNUstep applications.Compile
xpbs.mandxdnd.cintogpbsfor a wayland build when X11 is available, so the X11 owner reaches the desktop clipboard through XWayland. Guarding on X11 (rather than an unconditionalx11 waylandfilter) keeps a wayland build without X11 unchanged, since configure does not require X11 for the wayland server.Verified on a wayland session: after
wl-copy, anNSPasteboardprobe reads the copied text through the wayland-builtgpbs(both the wayland-native and X clipboard paths bridge via XWayland).Thanks to @danjboyd for the diagnosis and the reproduction.