Skip to content

Fix common dependencies check exception when composer.json has no dependencies - #50

Merged
cedric-anne merged 5 commits into
glpi-project:v1from
froozeify:remove-glpi-tools
Feb 5, 2026
Merged

cedric-anne merged 5 commits into
glpi-project:v1from
froozeify:remove-glpi-tools

Conversation

@froozeify

@froozeify froozeify commented Dec 31, 2025

Copy link
Copy Markdown
Member

In GLPI 11.0.6, tools will now be natively in GLPI.

This reveal a possible bug that could impact current and future implementation.
composer.json with no requirement will make the CI to crash at the step Check for common dependencies

Whatsapp plugin got a dedicated PR to test the modification (see in the feed under for the link)

@froozeify froozeify changed the title Remove glpi tools Fix common dependencies check exception when composer.json has no dependencies Dec 31, 2025
@froozeify
froozeify marked this pull request as ready for review December 31, 2025 14:42
@Rom1-B

Rom1-B commented Jan 5, 2026

Copy link
Copy Markdown
Contributor

This reveal a possible bug that could impact current and future implementation. composer.json with no requirement will make the CI to crash at the step Check for common dependencies

Is compose.json not useful in this case? Should it be removed completely?

@froozeify

froozeify commented Jan 5, 2026

Copy link
Copy Markdown
Member Author

@Rom1-B I'd rather keep it as it should still be used for the autoload for example.

I have updated the composer.json in plugin empty so the plugin tests autoload is configured for new plugin https://github.com/pluginsGLPI/empty/pull/57/changes#diff-d2ab9925cad7eac58e0ff4cc0d251a937ecf49e4b6bf57f8b95aab76648a9d34

…s like in whatsapp now) but still display other jq syntax error
Comment thread .github/workflows/continuous-integration.yml Outdated
Co-authored-by: Cédric Anne <cedric.anne@gmail.com>
@cedric-anne

Copy link
Copy Markdown
Member

Waiting for the tools to be merged into GLPI due to the readme file changes.

@cedric-anne
cedric-anne marked this pull request as draft January 5, 2026 13:20
Comment thread README.md Outdated
Co-authored-by: Cédric Anne <cedric.anne@gmail.com>
@froozeify
froozeify marked this pull request as ready for review February 4, 2026 09:22
@froozeify
froozeify requested a review from cedric-anne February 4, 2026 14:49
@cedric-anne
cedric-anne merged commit 03d0258 into glpi-project:v1 Feb 5, 2026
@froozeify
froozeify deleted the remove-glpi-tools branch February 5, 2026 08:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants