Conversation
cedric-anne
reviewed
Sep 21, 2026
cedric-anne
left a comment
cedric-anne
left a comment
Member
There was a problem hiding this comment.
I am not sure removing classes/methods right now is OK, now the RC2 has been released.
f2cmb
force-pushed
the
kb/faq/dropLegacyView
branch
from
September 22, 2026 14:32
ec1e8c9 to
2187110
Compare
f2cmb
changed the title
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes : glpi-project/roadmap#492
This PR stacks on #25576. Review only the changes it adds:
f2cmb/glpi@kb/faq/addHome...kb/faq/dropLegacyView
The side panel now covers browsing, so the pages it replaced are deleted, along with the code that only served them. The FAQ always shows an article, and a request without one goes to the home article.
The side panel also places articles with hidden parents in a single pass instead of a recursive walk, which drops the cycle guard it needed.
Nothing else in core used the removed code, but a plugin calling it will break. Old FAQ links carrying a search term or a tab now land on the home article.