FIX / Default value migrated from Formcreator wrongly checks first option when unmatched - #25564
Merged
cedric-anne merged 3 commits intoSep 22, 2026
Conversation
Mary-Clb
marked this pull request as ready for review
September 18, 2026 09:09
Code Review by Qodo🐞 Bugs (0) 📘 Rule violations (0) 📎 Requirement gaps (0)
Great, no issues found!Qodo reviewed your code and found no material issues that require reviewPowered by Qodo |
Mary-Clb
marked this pull request as draft
September 18, 2026 13:24
Mary-Clb
marked this pull request as ready for review
September 18, 2026 13:24
Rom1-B
approved these changes
Sep 18, 2026
trasher
approved these changes
Sep 21, 2026
ccailly
reviewed
Sep 21, 2026
ccailly
left a comment
ccailly
left a comment
Member
There was a problem hiding this comment.
The options can be read directly from convertExtraData to maintain the same indexing and sorting logic. The method already removes empty values.
ccailly
approved these changes
Sep 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
array_search()returning false for a stale/renamed default value was coerced to index 1 viafalse + 1, silently checking the first checkbox/radio option instead of leaving nothing selected.Screenshots :