Little funny quirk when editing modules setting of an agent

[g-bougard]

Code of Conduct

• I agree to follow this project's Code of Conduct

Disable plugins

• I reproduce the issue with all plugins disabled

Is there an existing issue for this?

• I have searched the existing issues

Version

11.0.6

Bug description

Agent modules setup is not always kept as shown on saving

Relevant log output

Page URL

No response

Steps To reproduce

1. Go to one agent Modules tab in Inventory Administration:
   
2. Select "VMware host remote inventory":
   
3. Click on update and here it's okay, "VMware host remote inventory" is enabled.
4. Now select also "Network inventory (SNMP)" and "Network discovery", click on "Update" and you see "VMware host remote inventory" is no more enabled:
   
5. If you click now on "VMware host remote inventory" and save, "Network inventory (SNMP)" and "Network discovery" are no more enabled... To make an infinitive loop go to point 4
6. Now just click on "Update" without selecting again "VMware host remote inventory", "Network inventory (SNMP)" or "Network discovery". You come back to point 1:
7. Click on the 3 not enabled modules and save, you now have all modules enables:
   
8. But don't click again on "Update" or you go back to point 1

Your GLPI setup information

No response

Anything else?

Also tested on 11.0.5

[g-bougard]

Just tested in 10.0.24 and there's no such problem.

[cconard96]

Wouldn't this be an issue in the plugin rather than the core?

[g-bougard]

No, agents are managed in glpi since GLPI 10.

[g-bougard]

Oups, @cconard96, you're right. If I disable the plugin, the module tab is removed. So yes, this is a plugin issue. You can moved it to glpi-inventory-plugin repository (I don't have that right).

[cconard96]

GitHub gives me the option to transfer it there but then says it can't.

[stonebuzz]

@g-bougard

can you try #938

[g-bougard]

Yes, it works.

Thank you.

[g-bougard]

It seems this bug is back with v1.6.8.

I installed a fresh 11.0.8 + glpi-inventory v1.6.8 plugin. And I see this problem again in modules activation UI on my first agent.

Not critical anyway.

[stonebuzz]

Have you reset glpi cache ?

[g-bougard]

No need to reset the cache:
New instance => new address => no cache

[g-bougard]

If I enable all modules on my agent, I have this in db:

MariaDB [glpi]> select * from glpi_plugin_glpiinventory_agentmodules;
+----+----------------------+-----------+------------+
| id | modulename           | is_active | exceptions |
+----+----------------------+-----------+------------+
|  1 | INVENTORY            |         1 | []         |
|  2 | InventoryComputerESX |         0 | ["1"]      |
|  3 | NETWORKINVENTORY     |         0 | ["1"]      |
|  4 | NETWORKDISCOVERY     |         0 | ["1"]      |
|  5 | DEPLOY               |         1 | []         |
|  6 | Collect              |         1 | []         |
+----+----------------------+-----------+------------+

In the UI, I'm with what shows the step 7 in this issue description. Then I hit "Update" button. Then I'm back with what shows step 6 and in db I have:

MariaDB [glpi]> select * from glpi_plugin_glpiinventory_agentmodules;
+----+----------------------+-----------+------------+
| id | modulename           | is_active | exceptions |
+----+----------------------+-----------+------------+
|  1 | INVENTORY            |         1 | []         |
|  2 | InventoryComputerESX |         0 | []         |
|  3 | NETWORKINVENTORY     |         0 | []         |
|  4 | NETWORKDISCOVERY     |         0 | []         |
|  5 | DEPLOY               |         1 | []         |
|  6 | Collect              |         1 | []         |
+----+----------------------+-----------+------------+

Exceptions seems to be lost even if all modules were selected during last agent modules activation update.

[g-bougard]

Indeed the comportment is a little different now: before, modules enabled as exceptions were reversed on update, now they are just disabled on update.