'bounds' is messing up the x, y coordinnates

[Berhinj]

This used to not be the case but it's suddenly popping up, I don't know what happened.

Suddenly the 'bounds' parameter from stackstac.stack function messes up the original coordinates of the images.
When using the 'bounds' parameter, instead of preserving the original x/y coordinnates, stackstac modifies them and they'll give you float values:

import numpy as np
import rasterio
import stackstac
import rioxarray as rxr  # noqa: F401
import json
import pystac_client

bbox = [2.3575522081018616, 46.9821947096507, 2.373435778967132, 46.98773884336863]
bbox_utm = [451141.38241652114, 5203375.974548349, 452354.2625236209, 5204001.850759215]
datetime="2022-12-01/2023-02-10"
cloud_cover=30
processing_level="l2"


URL = "https://landsatlook.usgs.gov/stac-server"

catalog = pystac_client.Client.open(URL)

params = dict(
    max_items=None,
    limit=1000,
    bbox=bbox,
    datetime=datetime,
    query={
        "eo:cloud_cover": {"lt": cloud_cover},
        "landsat:collection_category": {"eq": "T1"},
        "landsat:collection_number": {"eq": "02"},
        "platform": {"in": ["LANDSAT_8", "LANDSAT_9"]},
    },
)

xsr = catalog.search(collections=["landsat-c2l2-sr"] , **params).item_collection()

da = stackstac.stack(
    xsr[0],
    assets={"image/tiff", "image/vnd.stac.geotiff", "image/x.geotiff"},
    bounds=list(aoi.to_crs(crs_utm).bbox),
    snap_bounds=False,
    gdal_env=stackstac.DEFAULT_GDAL_ENV.updated(
        always=dict(session=rasterio.session.AWSSession(requester_pays=True))
    ),
)
da.x

Will give you

While removing the 'bounds' will give you the

da = stackstac.stack(
    xsr[0],
    assets={"image/tiff", "image/vnd.stac.geotiff", "image/x.geotiff"},
    # bounds=list(aoi.to_crs(crs_utm).bbox),
    snap_bounds=False,
    gdal_env=stackstac.DEFAULT_GDAL_ENV.updated(
        always=dict(session=rasterio.session.AWSSession(requester_pays=True))
    ),
)
da.x

will give you the original integer like x, y coordinnates

[gjoseph92]

@Berhinj I'm looking at this now, but I can't reproduce your example because aoi and crs_utm that you're referencing in your code aren't defined.

Without that, I can't really see what the issue is here. It's not surprising that the output changes between passing and not passing bounds. When you don't pass it, stackstac picks bounds for you based on the extent of all the assets. When you do, you're defining your own bounds, which could be completely different.

Notice, for example, that with the bounds you specify, you're getting a 40px wide image. If you don't specify bounds, the whole thing is 7821px wide!

Also, because snap_bounds=False, it's not surprising that the coordinates are floats. See the docs for snap_bounds: "snap the bounds to whole-number intervals of resolution to prevent fraction-of-a-pixel offsets".