Repository navigation
Retain managed environment after preview cleanup - #451
Merged
Merged
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 1ee61678-f309-44b2-b281-54e456f7cc5d
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the preview deployment GitHub Actions workflow cleanup behavior to delete only the per-preview apps/resources while retaining the shared Azure Container Apps managed environment, reducing churn and avoiding unnecessary recreate cycles.
Changes:
- Removed the cleanup step that deleted the Azure Container Apps managed environment.
- Updated the PR cleanup comment to state that the preview apps were removed while the shared managed environment was retained.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.
Suppressed comments (1)
.github/workflows/preview-deploy.yml:451
- This PR modifies a GitHub Actions workflow. Per repo guidelines, changes under
.github/workflows/should only be made with explicit approval (see.github/copilot-instructions.md:21-24). Please ensure that approval is documented (e.g., in the PR description or via an agreed maintainer sign-off) before merging.
const body = `## 🧹 Shared Preview Apps Cleaned Up\n\n` +
`The shared preview apps have been removed (${reason}). The shared managed environment was retained for future deployments.`;
Contributor
🧹 Shared Preview Apps Cleaned UpThe shared preview apps have been removed (PR was merged/closed). The shared managed environment was retained for future deployments. |
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Rationale
An empty consumption-based Container Apps managed environment has no ACA compute charge. Retaining it avoids repeatedly deleting and recreating the shared environment.
Validation
.github/workflows/preview-deploy.ymlsuccessfullygit diff --checkpassedSecurity
npm audit --audit-level=high --omit=devreports the existing high-severitybrace-expansionadvisory; this workflow-only change does not alter dependencies