Repository navigation
feat: surface backend package-path advisories in CLI and MCP grep - #516
Merged
Merged
Conversation
Select and validate backend path warnings in both response modes, preserve them through shared projections, and display safely quoted unverified alternatives without changing search scope. Cover short-wait partial pages, quoting, native failures and CLI/MCP parity; document production schema and review prerequisites.
Reuse the shared control escaper after JSON serialization so C1 controls cannot remain literal in advisory rows. Extend the existing quote test to prove terminal safety and exact JSON and shell round trips.
Summarize backend evidence as one warning per distinct correction instead of dumping explanations and alternate targets. Share wording across CLI and MCP text/JSON, preserve native results and scope, and cover control-safe warning parity.
Apply the clean Claude round’s documentation corrections, retain the compact qualification evidence, and move the existing authenticated smoke fixture gap to the backlog. Remove the completed implementation plan after review without changing runtime behavior.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Unified grep now reports backend-diagnosed package-path mistakes as one compact warning per distinct correction in CLI/MCP text and JSON:
No verbose explanation or alternate-target dump. JSON
pathWarningscontains these same strings. The backend owns diagnosis and suggested paths; the client neither guesses nor retries. Native matches, failures, preparation and cursors remain intact. Core service consumers retain validated backend metadata.Validation:
Final CI at
ce5c3b2is green: Linux/Windows tests, build checks, MCP package validation, secret scan, Bun and Node 20-26 compatibility. CI run.Full unit suite: 6,681 passed. Final focused grep suites: 184 passed, 1,359 assertions, including text/JSON equality, controls, deduplication, multiple warnings, zero hits, native failures and short-wait pending pages.
Typecheck, format, builds and outside-workspace package validation passed. Lint retains 19 preexisting warnings in unchanged code.
Source and built unauthenticated smoke passed. Built CLI/MCP dev prefix/exact qualification passed in text and JSON, retaining the exact-path native failure.
Targeted agent eval: original scope preserved in text/JSON calls, correction recognized, no alternative executed; final inconclusive/high confidence, no recorded isolation violations or graded quality claim.
Review and rollout:
docs/plans/open-backlog.md. Reviewer retained for follow-up. No merge/release/deploy approval is implied.v20.10.0now resolvesv20.10.0+incompatible). Assertions were not weakened.remote-mcppackage upgrade/deployment are still required and separately authorized.Durable contract:
docs/implementation/unified-grep.md. The backend backlog entry needs its owner's closure after shipping. No merge, release, publish or deploy performed.