Improve "Require Stim" Settings to Actually Make Player Use Injector - #1
Open
dounai2333 wants to merge 1 commit into
Open
Improve "Require Stim" Settings to Actually Make Player Use Injector#1dounai2333 wants to merge 1 commit into
dounai2333 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I really love the idea of requiring a specific injector to revive yourself. However, after trying it out, I quickly realized that it wasn't about "use an injector on yourself to get back up", but an "the injector simply gets deleted from your inventory".
This isn’t a big deal if the required item is something common like "Adrenaline", but it becomes a significant issue when the injector is expensive (100k eTG-change). Essentially, you’ve used the injector, but you don’t receive the beneficial effects that should come with it. This PR aims to fix that.
As a small additional note, this change will also correctly cause "The Survivalist Path - Tough Guy" to fail when you revive yourself with the "Require Stim" setting enabled, since the injector is now properly registered as consumed.