Repository navigation
Conversation
…string The native iOS breadcrumb's url is sanitized (query moved to http.query or filtered, percent-decoded, credentials replaced), so the exact url match against the raw JS xhr/fetch url failed. Compare normalized urls instead and ignore the query. Fixes #6872 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Contributor
Semver Impact of This PR⚪ None (no version bump detected) 📋 Changelog PreviewThis is how your changes will appear in the changelog.
🤖 This preview updates automatically when you update the PR. |
Contributor
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
✅ Bugbot reviewed your changes and found no new issues!
Comment @cursor review or bugbot run to trigger another review on this PR
Reviewed by Cursor Bugbot for commit 2de5669. Configure here.
antonis
marked this pull request as ready for review
October 13, 2026 09:49
| nativeUrl === jsUrl || | ||
| nativeUrl === `${jsUrl}/` || | ||
| nativeUrl.startsWith(`${jsUrl}?`) || | ||
| nativeUrl.startsWith(`${jsUrl}/?`) |
Collaborator
There was a problem hiding this comment.
Is there a chance the question mark will be %3F?
| /** Matches the native URL to the JS one, with or without a trailing slash or query. */ | ||
| function isSameHttpUrl(nativeUrl: string, jsUrl: string): boolean { | ||
| return ( | ||
| nativeUrl === jsUrl || |
Collaborator
There was a problem hiding this comment.
Isnt this check redundant since we do an equal check on line 139?
Collaborator
|
Q: Isn't it possible to know if the request originated from the JavaScript layer? This way we could simply filter out these requests. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📢 Type of change
📜 Description
URLs are now normalized before comparing:
?, because after decoding a?may belong to the path./,?…or/?…. Identical raw URLs still always match.💡 Motivation and Context
Fixes #6872
💚 How did you test it?
CI, Manual
📝 Checklist
sendDefaultPIIis enabled.🔮 Next steps