Repository navigation
Circular Layout 0.9.4: don't give NaN positions to nodes without size - #361
Merged
Merged
Conversation
The layouts space nodes by their size, so a graph whose nodes all have size 0 (or a single such node) made the circumference 0 and the angle Infinity, giving NaN positions that graphstore rejects. Use a minimum size of 1 in the circumference and angle computations. Version 0.9.4. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Found by the SPI contract tests of gephi-plugins-tests (
LayoutContractTest), run against Gephi 0.11.4.The three layouts (Circle, Dual Circle, Radial Axis) space nodes by their size. When all nodes have size 0, e.g. a graph of nodes ranked down to zero, or a single such node, the circumference is 0 and the angle
2π / 0is Infinity.Infinity × 0then gives NaN positions, and graphstore throwsx cannot be NaNfromgoAlgo().LayoutHelper.nodeSize(Node), a node's size with a minimum of 1, and used it in place ofn.size()for the circumference and angle computations (9 places in the three layouts).Verified: the layout contract tests (gephi-plugins-tests 1.1.1) pass on this module, which failed 5 of them before. Short-lived branch off
master-forge, so the diff is only these files.