Skip to content

Try to add link to file formats into import dialog - #340

Closed
abitrolly wants to merge 1 commit into
gephi:mainfrom
abitrolly:patch-1
Closed

abitrolly wants to merge 1 commit into
gephi:mainfrom
abitrolly:patch-1

Conversation

@abitrolly

Copy link
Copy Markdown
Contributor

Pull request type

Check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

NOTE: Try to limit your pull request to one type, submit multiple pull requests if needed.

What is the current behavior?

Issue Number: gephi/gephi-documentation#15

Documentation on file formats is not linked from import dialog.

What is the new behavior?

User should be able to follow the docs to see how to create the file for import into Gephi Lite.

Other information

@abitrolly

Copy link
Copy Markdown
Contributor Author

I am not sure it is going to work. React may render it as static. Need to setup local environment to test.

@abitrolly

Copy link
Copy Markdown
Contributor Author

Nah. I doesn't work.

image

Took me 3 hours to weed out all gotchas to test it.

@abitrolly

Copy link
Copy Markdown
Contributor Author

The translated text is passed down to DropInput component as helpText

<DropInput
value={file}
onChange={(file) => setFile(file)}
helpText={t("graph.open.local.dragndrop_text")}

which sees it as a string

export const DropInput: FC<
PropsWithChildren<{
value: File | null;
onChange: (file: File | null) => void;
helpText: string;
accept: Accept;

and the string is rendered escaped.

Not sure what is the proper React way to fix that.

@sim51

sim51 commented Sep 14, 2026

Copy link
Copy Markdown
Collaborator

Hi,

Thanks for your PR! However, don’t waste your time on this particular approach.

We have other places with modals where it would be useful to add a help icon that opens the documentation website in a new tab (for example, for script layout, GitHub auth, etc.).

This should not be part of the i18n system.

I also have a couple of questions for you:

Did you have any trouble dealing with file formats in Gephi Lite?
You mentioned: “It took me 3 hours to weed out all the gotchas to test it.” From your perspective, what could we do to improve the developer experience around this?

Thanks!

@sim51

sim51 commented Sep 15, 2026

Copy link
Copy Markdown
Collaborator

Closing this PR.
But I created this issue : #343

@sim51 sim51 closed this Sep 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants