Repository navigation
fix(redis): ping the subscription connection to detect half-open sockets - #5
Merged
Merged
Conversation
LounisBou
marked this pull request as ready for review
September 18, 2026 13:06
ArthurRmd
approved these changes
Sep 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Redis transport opens two connections from the same DSN, one for commands and one for the pub/sub subscription. The periodic ping only reached the command connection, so a half-open subscription socket went unnoticed: the hub kept answering publish requests while every subscriber stopped receiving anything.
The ping now runs on both connections. Paired with a non-zero readTimeout it turns a silent socket into a rejected promise, which reaches Hub::die and lets the supervisor restart the hub.
This is what kept four production hubs frozen for 35 hours while the process stayed alive and the Redis instance stayed up.
Covers the ping method with two tests, so its coverage-ignore marker is gone.