Simulator-->compute_reactions: Apply hanging node constraints to distributed_reaction_vector#7012
Open
GTAIto wants to merge 1 commit into
Open
Conversation
…ributed_reaction_vector
tjhei
approved these changes
Jun 19, 2026
tjhei
left a comment
tjhei
left a comment
Member
There was a problem hiding this comment.
Thank you, Garrett!
This was discussed offline via email and @jdannberg and I agreed, that this is the right fix.
Member
|
One of the test outputs changed. @GTAIto can you download the changes-test-results-9.6.diff, apply it, and push to this PR? (see https://aspect-documentation.readthedocs.io/en/latest/user/extending/testing/writing-tests.html#updating-test-results-for-pull-requests for details) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Simulator:: compute_reactions
Hanging node constraints were not applied to distributed_reaction_vector
1894 // Apply hanging node constraints but not Dirichet bcs, while preserving periodic bcs
1895 constraints.distribute(distributed_reaction_vector);
[ X] I have read the guidelines in our CONTRIBUTING.md document.
[ X] I have followed the instructions for indenting my code.
See attached pdf for my test that the BCs were preserved.
Fill_reaction_rate_hanging_nodes.pdf