refactor(ethexe-cli): use sdk for ethexe-cli tx subcommand#5569
refactor(ethexe-cli): use sdk for ethexe-cli tx subcommand#5569playX18 wants to merge 10 commits into
Conversation
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request refactors the ethexe-cli transaction subcommand to utilize the ethexe-sdk as the primary interface. By abstracting the transaction-facing API, the CLI codebase is simplified and becomes less coupled to underlying RPC implementation details. The SDK has been improved with a builder pattern and support for optional RPC clients, enhancing its usability and flexibility for various deployment scenarios. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request refactors the ethexe CLI and SDK to integrate the new ethexe-sdk crate, replacing direct dependencies on ethexe-ethereum and jsonrpsee. It introduces VaraEthApiBuilder for constructing VaraEthApi clients, supports optional WebSocket RPC configurations, and encapsulates injected transaction details into InjectedMessageResult. Feedback on the changes suggests enforcing mutual dependencies on CLI arguments using clap attributes and optimizing RPC calls in the query command to avoid duplicate state hash lookups.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
Closes #5111
Summary
Transitioned ethexe-cli tx to use ethexe-sdk as the transaction-facing API instead of constructing ethexe_ethereum and Vara.ETH RPC clients directly.
This adds SDK builder/default helpers, supports Ethereum-only SDK instances, keeps Vara.ETH RPC optional for RPC-dependent calls, and re-exports only the data types needed by the
CLI.
How to test
Notes
No breaking CLI behavior is intended. ethexe-cli no longer depends directly on ethexe-ethereum or jsonrpsee for tx flows.
Checklist
type(scope): description)