Skip to content

refactor(ethexe-cli): use sdk for ethexe-cli tx subcommand#5569

Open
playX18 wants to merge 10 commits into
masterfrom
ap/ethexe-cli-sdk
Open

refactor(ethexe-cli): use sdk for ethexe-cli tx subcommand#5569
playX18 wants to merge 10 commits into
masterfrom
ap/ethexe-cli-sdk

Conversation

@playX18

@playX18 playX18 commented Jun 8, 2026

Copy link
Copy Markdown
Member

Closes #5111

Summary

Transitioned ethexe-cli tx to use ethexe-sdk as the transaction-facing API instead of constructing ethexe_ethereum and Vara.ETH RPC clients directly.

This adds SDK builder/default helpers, supports Ethereum-only SDK instances, keeps Vara.ETH RPC optional for RPC-dependent calls, and re-exports only the data types needed by the
CLI.

How to test

  cargo fmt --check
  cargo check -p ethexe-sdk
  cargo check -p ethexe-cli

Notes

No breaking CLI behavior is intended. ethexe-cli no longer depends directly on ethexe-ethereum or jsonrpsee for tx flows.

Checklist

  • PR title follows Conventional Commits (type(scope): description)
  • Single logical change
  • Tests added or updated (if logic changed)
  • Docs updated (if needed)

@playX18 playX18 self-assigned this Jun 8, 2026
@playX18 playX18 added type: refactor Internal improvements without changing behavior scope: vara.eth Vara Ethereum application layer (L2) ci: full Run full CI matrix (all platforms and profiles) labels Jun 8, 2026
@gemini-code-assist

Copy link
Copy Markdown
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request refactors the ethexe-cli transaction subcommand to utilize the ethexe-sdk as the primary interface. By abstracting the transaction-facing API, the CLI codebase is simplified and becomes less coupled to underlying RPC implementation details. The SDK has been improved with a builder pattern and support for optional RPC clients, enhancing its usability and flexibility for various deployment scenarios.

Highlights

  • Refactoring Transaction Flows: Transitioned ethexe-cli transaction logic to use the ethexe-sdk, reducing direct dependencies on ethexe-ethereum and jsonrpsee.
  • SDK Enhancements: Introduced VaraEthApiBuilder to support flexible SDK configuration, including support for Ethereum-only instances where Vara.ETH RPC is optional.
  • Dependency Management: Cleaned up Cargo.toml and Cargo.lock by removing redundant dependencies and centralizing configuration through the SDK.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request refactors the ethexe CLI and SDK to integrate the new ethexe-sdk crate, replacing direct dependencies on ethexe-ethereum and jsonrpsee. It introduces VaraEthApiBuilder for constructing VaraEthApi clients, supports optional WebSocket RPC configurations, and encapsulates injected transaction details into InjectedMessageResult. Feedback on the changes suggests enforcing mutual dependencies on CLI arguments using clap attributes and optimizing RPC calls in the query command to avoid duplicate state hash lookups.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Comment thread ethexe/cli/src/commands/tx.rs Outdated
Comment thread ethexe/cli/src/commands/tx.rs Outdated
Comment thread ethexe/sdk/src/api.rs Outdated
Comment thread ethexe/sdk/src/api.rs
Comment thread ethexe/sdk/src/api.rs Outdated
Comment thread ethexe/sdk/src/api.rs
Comment thread ethexe/sdk/src/mirror.rs Outdated
Comment thread ethexe/sdk/src/lib.rs Outdated
Comment thread ethexe/sdk/src/api.rs Outdated
Comment thread ethexe/sdk/src/api.rs Outdated
Comment thread ethexe/sdk/src/lib.rs Outdated
Comment thread ethexe/sdk/src/mirror.rs Outdated
Comment thread ethexe/sdk/src/lib.rs Outdated
Comment thread ethexe/sdk/src/api.rs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci: full Run full CI matrix (all platforms and profiles) scope: vara.eth Vara Ethereum application layer (L2) type: refactor Internal improvements without changing behavior

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Migrate ethexe-cli to the new client implementation

2 participants