Skip to content

Stabilize preset draft action test hydration - #26

Merged
gateway merged 1 commit into
mainfrom
codex/preset-actions-test-synchronization
Oct 13, 2026
Merged

gateway merged 1 commit into
mainfrom
codex/preset-actions-test-synchronization

Conversation

@gateway

@gateway gateway commented Oct 13, 2026

Copy link
Copy Markdown
Owner

Summary

The fresh-preset/older-run test starts its button query while the saved session is still hydrating. Controlled event-loop pressure reproduces the missing-button failure. Await React’s asynchronous setup before checking the draft action, without extending a polling timeout or changing production behavior.

- render preset session; poll for Create test graph
+ await act(render preset session); assert Create test graph

This demonstrates a timing mechanism consistent with the intermittent failure; the historical run did not capture enough timing information to prove its exact cause.

Evidence

  • Before: controlled pressure reproduces the missing-button failure twice; removing the older run still fails.
  • After: the same pressure passes twice with awaited setup; all 13 preset-action tests pass. The fresh draft and older completed run remain in the test.
  • Independent Standards/Spec reviews: zero code findings each.
  • Read-only Codex browser smoke loaded existing Graph/Assistant history and a saved preset draft. The exact test fixture remains automated-only; an existing result-loading error was observed separately and is not claimed fixed.
  • Full local frontend run was cancelled to avoid overloading the development machine. Local typecheck encountered syntax errors in generated Next development types during startup; lint was not reached. CI is required before merge.
  • No paid generation or saved-data edits.

Merge Danger

Door: two-way

Blast Radius: tests

One test-only synchronization change; no application, schema or dependency changes.

Controlled event-loop pressure can expire the button query before saved-session hydration. Await React setup, then assert the fresh-draft action synchronously; retain the older completed-run fixture.
@gateway
gateway marked this pull request as ready for review October 13, 2026 05:31
@gateway
gateway merged commit 7e5b22b into main Oct 13, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant