Skip to content

[DRAFT] Collapse Readiness#2851

Draft
grolu wants to merge 12 commits into
masterfrom
enh/collapse_readiness
Draft

[DRAFT] Collapse Readiness#2851
grolu wants to merge 12 commits into
masterfrom
enh/collapse_readiness

Conversation

@grolu

@grolu grolu commented Mar 26, 2026

Copy link
Copy Markdown
Member

What this PR does / why we need it:

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Release note:

@gardener-prow gardener-prow Bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 26, 2026
@gardener-prow

gardener-prow Bot commented Mar 26, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign klocke-io for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@gardener-prow gardener-prow Bot added the do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. label Mar 26, 2026
@coderabbitai

coderabbitai Bot commented Mar 26, 2026 •
edited
Loading

Copy link
Copy Markdown

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 88b59f07-aaf0-44df-8d87-5cf9f29d2424

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch enh/collapse_readiness

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@gardener-prow gardener-prow Bot added cla: yes Indicates the PR's author has signed the cla-assistant.io CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Mar 26, 2026
@gardener-ci-robot

gardener-ci-robot commented May 1, 2026

Copy link
Copy Markdown
Contributor

The Gardener project currently lacks enough active contributors to adequately respond to all PRs.
This bot triages PRs according to the following rules:

  • After 30d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 14d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

  • Mark this PR as active with /lifecycle active
  • Mark this PR as fresh with /remove-lifecycle stale
  • Mark this PR as rotten with /lifecycle rotten
  • Close this PR with /close

/lifecycle stale

@gardener-prow gardener-prow Bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label May 1, 2026
@grolu grolu added lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels May 13, 2026
@grolu grolu force-pushed the enh/collapse_readiness branch from 4ff9d41 to b4c86c7 Compare June 11, 2026 21:55
@gardener-prow gardener-prow Bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 11, 2026
@grolu grolu changed the title [DRAFT] collapse tags (vibe coded) [DRAFT] Collapse Readiness Jun 11, 2026
grolu and others added 7 commits June 12, 2026 13:28
@grolu
collapse tags (vibe coded)
bd14bae
@grolu
auto scroll container
c711afe
@grolu
Further Improvements
39a6c4a
@grolu
Reset scroll position after leaving container
7dd0b83 
Fix ScrollContainer width
@petersutter @grolu
style(shoot-list): widen readiness column to 200px
43459a3
@petersutter @grolu
fix(scroll-container): track scroll size reactively for fade
a6f4d8c 
Reading scrollWidth/scrollHeight inside a computed did not register
as a reactive dependency, so the fade overlay only updated on scroll
events. Async content growth (e.g. expanding chips) left the fade
stuck at zero until the user scrolled. Observe size and DOM mutations
to keep the fade in sync.

Also cap fade length at 60px so it stays narrow on wider containers.
@petersutter @grolu
feat(status-tags): improve a11y and keep focused chip in view
1f185f1 
Collapsed chips now use a visually-hidden label and aria-label so
screen readers and reduced-motion users keep full context. Tabbing
through chips scrolls the readiness container to keep the focused
chip in view, matching the existing mouse-edge auto-scroll.
@grolu grolu force-pushed the enh/collapse_readiness branch from 3efe79f to 1f185f1 Compare June 12, 2026 11:29
@petersutter
fix(status-tags): increase tooltip open-delay to 750ms
f8c1ab7
@petersutter
fix(status-tags): ignore programmatic focus from closing tooltip
a7dc4c8 
Vuetify's v-tooltip restores focus to its activator on close
(VOverlay returnFocusToActivator). Hovering a chip long enough
to open its tooltip, then mousing away, focused the chip — it
stayed expanded and showed the v-chip focus border.

Gate onFocus/onFocusIn on :focus-visible so only keyboard focus
expands chips and pulls the container into hovered state.
@petersutter
fix(status-tags): bump collapse delay to 3000ms
de83d4d
@petersutter
test(status-tags): sync collapse timer in spec to 3500ms
830aa97
@petersutter
fix(status-tags): keep chips expanded while popover is open
fa84947 
Chips no longer collapse when the pointer/focus leaves the
cell while a popover from that cell is still open. Collapse
is deferred until the popover closes.
@grolu grolu added the area/ipcei IPCEI (Important Project of Common European Interest) label Jun 22, 2026
@grolu grolu mentioned this pull request Jun 22, 2026
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@holgerkoser holgerkoser Awaiting requested review from holgerkoser holgerkoser will be requested when the pull request is marked ready for review holgerkoser is a code owner

@klocke-io klocke-io Awaiting requested review from klocke-io klocke-io will be requested when the pull request is marked ready for review klocke-io is a code owner

@petersutter petersutter Awaiting requested review from petersutter petersutter will be requested when the pull request is marked ready for review petersutter is a code owner

Assignees

No one assigned

Labels

area/ipcei IPCEI (Important Project of Common European Interest) cla: yes Indicates the PR's author has signed the cla-assistant.io CLA. do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@grolu @gardener-ci-robot @petersutter