Added branding for landing page - #156
Conversation
ganto
left a comment
ganto
left a comment
There was a problem hiding this comment.
Thanks a lot for this PR. Looks good to me with a few minor adjustments.
| --- | ||
| branding: | ||
| title: Pkgproxy Application | ||
| description: Caching forward proxy for Linux package repositories |
There was a problem hiding this comment.
As I'm including the pkgproxy.yaml as default config into the container image can you please comment the these settings so that the defaults from the binary are used and the settings here are simply used as hints for people who want to customize these.
| The config snippets shown on the landing page (`GET /`) need pkgproxy's own | ||
| address, e.g. `baseurl=http://<pkgproxy>/fedora/...`. Rather than relying on a | ||
| server-side setting, this is filled in automatically, with no configuration | ||
| needed: |
There was a problem hiding this comment.
You mentioned this before but I don't really see how this is true with the code of this PR. I also don't really think that this is something that I would want as I often use browsers that don't support Javascript.
I think this entire section of the README.md is not needed.
|
|
||
| Both fields are optional and independent — omitting `branding` entirely, or | ||
| leaving one of the two fields unset, falls back to the default "pkgproxy" title | ||
| and "Caching forward proxy for Linux package repositories." description. The |
There was a problem hiding this comment.
Could you link here to the defaults defined in the pkg/pkgproxy/landing.go instead of literally duplicating the settings.
2 participants
Added in branding for the landing page. Parameters are configured via the pkgproxy config file.