Add xfail tests documenting non-unique generated RSF labels#992
Open
d-kad wants to merge 2 commits into
Open
Conversation
Member
|
This is a good point and something that was in the back of my mind. But also as I note in #991, actually we should be thinking about what we want auto-generated labels to be especially now that actions do (or shortly will) be required to have nonempty labels. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the changes in this PR
Reduced-strategy labels are generated by concatenating action numbers with no separator,
so they are non-unique once an information set has ten or more actions: assignments
(1, 11)and(11, 1)both render as
"111". This violates the per-player label uniqueness that #981 enforces on user-set labels,and it breaks NFG round-tripping —
WriteNfgFileemits the duplicate labels andReadNfgFilethen rejects.This PR documents the bug with two
xfailtests for the smallest tree that produces exactly one collision.