Repository navigation
Adapt to datafusion-distributed's parameter-encoded dataset layout - #69
Merged
Merged
Conversation
datafusion-distributed PRs #819/#820 replaced short dataset names (tpch/sf1) with paths that encode every generation parameter (tpch_parquet/scale_factor=1/max_file_size=.../dictionary=pages/sorted=false) and dropped the gen-*.sh scripts in favor of `dfbench prepare-*`. - Update dataset path parsing, suite derivation, and docs across both components to the new layout. - Resolve legacy short names (tpch/sf10, clickbench/0-100, ...) to their current equivalent in both the interactive CLI and bot comments. - Replace the bot's dataset allowlist with a live check against the dataset bucket's `_SUCCESS` markers instead of a hardcoded list. - Remove `dataset-destroy`: this repository does not manage dataset lifecycle. Add `list-datasets` to inspect what has finished generating in the bucket.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
tpch/sf1) with paths that encode every generation parameter (tpch_parquet/scale_factor=1/max_file_size=134217728/dictionary=pages/sorted=false) and removed thegen-*.shscripts in favor ofdfbench prepare-*. This updates dataset path parsing, suite derivation, schema naming, and docs across both components to match.tpch/sf10,tpcds/sf1,clickbench/0-100, ...) resolve transparently to their current equivalent, both in the interactive CLI (benchmarks-remote) and in bot comments (benchmark-bot)._SUCCESScompletion markers live, before enqueueing a job.dataset-destroy: this repository doesn't manage dataset lifecycle (generation or removal happen in the source checkout / directly in S3). Addedlist-datasetsso it's easy to see what has actually finished generating in the bucket.Test plan
npm run buildfrom the repo rootnpm testfrom the repo root (format, lint, both test suites — 77 benchmark-bot + 70 benchmarks-remote + 14 infra tests, all passing)npm run list-datasetsagainst the live dataset bucket and confirmed it matches the actual bucket contents