[AI generated PR] Fix tab switching infinite loop when limitToCurrentWindow is true - #158
Open
lp-lima wants to merge 1 commit into
Open
[AI generated PR] Fix tab switching infinite loop when limitToCurrentWindow is true#158lp-lima wants to merge 1 commit into
lp-lima wants to merge 1 commit into
Conversation
lp-lima
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Disclaimer
I'm wholly ignorant on the code, the language, Chrome extensions and whatnot. I just liked the extension, asked the AI to fix this minor bug locally. When I saw it worked, I wanted to contribute back.
AI-generated PR description
This PR fixes a bug where rapidly navigating backwards through tabs with 'Limit recent tabs to the current browser window' enabled could cause the navigation index to double-decrement. If it missed the single exit condition due to this skipping, the recursive
switchTabsfunction would fall into an infinite loop and crash the background service worker via a stack overflow.Changes:
.catch()block to the main promise chain to gracefully recover if the background service worker ever hits a stack overflow.switchTabsso it doesn't double-decrement when navigating backwards across windows.skipCount) fail-safe to gracefully exit if it iterates through the entire tab array without finding a matching tab.