feat: add School (campus/branch) doctype + Student school/reference_number fields#436
Open
ankitpatil-ap wants to merge 1 commit into
Open
feat: add School (campus/branch) doctype + Student school/reference_number fields#436ankitpatil-ap wants to merge 1 commit into
ankitpatil-ap wants to merge 1 commit into
Conversation
…/program fields Signed-off-by: ankitpatil-ap <ankitpatil.v@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Adds a generic, dependency-free School (campus/branch) doctype to Education, plus three fields on Student:
Schooldoctype —school(name / autoname),description,location. No links to ERPNext (Company/Warehouse) and no region-specific fields, so Education gains no new app dependency.Student.school— Link → SchoolStudent.reference_number— Data (external / library-card identifier)Student.program— Link → Program (convenience field; see note)Why
Multi-campus schools need a branch/campus master and a way to tag a Student with their branch and an external reference number. Today this gets re-implemented as custom fields in every project. I built an open-source school library circulation app on top of Education that reads these fields, and the generic pieces belong in Education so any school benefits.
Note on
Student.programEducation models program membership via Program Enrollment. I included a direct
Student.programlink as a convenience because downstream apps read it directly — but I'm happy to drop it and rely on Program Enrollment if you'd prefer. Likewise,Schoolis intentionally minimal and I'm happy to rename it (Campus/Branch) if that fits better.Testing
bench --site <site> migratesyncs theSchooldoctype and the new Student fields.TestSchoolstub; happy to expand coverage as guided.Happy to open a separate discussion/issue first if the team prefers that for new doctypes.