Repository navigation
Migrate Dashboard GridView to RecyclerView, theme gauge colours - #362
Merged
fr3ts0n merged 1 commit intoSep 8, 2026
Merged
Conversation
DashBoardActivity's GridView/ArrayAdapter becomes a RecyclerView with GridLayoutManager, and obd_gauge.xml's hardcoded dark-only gauge colours (#A0000000/#20FFFFFF/#ffffffff) become theme-aware attributes (colorSurfaceVariant/colorOutlineVariant/colorPrimary), fixing contrast in light mode. ObdGaugeAdapter gains its own OnItemLongClickListener interface since RecyclerView has no built-in equivalent to AdapterView.OnItemLongClickListener. Verified on-device (Pixel 10, Android 17): dashboard renders via the new RecyclerView, colours look correct in dark theme, live PV updates render via the new ViewHolder lookup, and long-press on a gauge still opens PidCustomization. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01TMLp25CwrBe5r1vUrE4jJ5
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Continues the Material-migration work tracked in #104 (item 5, device pickers, merged in #360).
What
DashBoardActivity'sGridView/ArrayAdapter→RecyclerView/GridLayoutManagerobd_gauge.xml's hardcoded dark-only gauge colours (#A0000000/#20FFFFFF/#ffffffff) → theme-aware attributes (?attr/colorSurfaceVariant/?attr/colorOutlineVariant/?attr/colorPrimary), fixing contrast in light modeObdGaugeAdaptergains its ownOnItemLongClickListenerinterface, sinceRecyclerViewhas no built-in equivalent toAdapterView.OnItemLongClickListenerTesting
Build/lint/unit tests clean (
assembleDebug,lintDebug— no new findings, same pre-existing baseline as before,testDebugUnitTest). Verified on-device (Pixel 10, Android 17): dashboard renders correctly via the newRecyclerView, gauge colours look correct in dark theme, live PV value updates render correctly through the newViewHolderlookup, and long-press on a gauge still opensPidCustomizationcorrectly.No new tests added — this is a rendering/adapter-wiring change with no existing unit-test seam in this layer, consistent with the sibling device-picker migration in #360.
🤖 Generated with Claude Code
https://claude.ai/code/session_01TMLp25CwrBe5r1vUrE4jJ5