Skip to content

fix(connectivities)!: EN-2807 prepare v3.21.2 with Ledger scope migration - #575

Merged
Dav-14 merged 2 commits into
mainfrom
codex/fix-connectivity-ledger-scopes-20261106
Nov 6, 2026
Merged

Dav-14 merged 2 commits into
mainfrom
codex/fix-connectivity-ledger-scopes-20261106

Conversation

@Dav-14

@Dav-14 Dav-14 commented Nov 6, 2026 •

Copy link
Copy Markdown
Contributor

Summary

Fix EN-2807, coordinating with Connectivity Core #524 / EN-2806:

existing Connectivity Credentials
  → reconcile five canonical Ledger RC.2/RC.3 scopes in place
  → wait for observedGeneration
  → preserve key identity and distributed Secret references

Replace ledger:AccountRead/LedgerWrite/TransactionWrite/MetadataWrite/QueryWrite with ledger:ReadAccount/WriteLedger/WriteTransaction/WriteMetadata/WriteQuery. Retain non-superuser access and existing ownership/readiness checks.

Prepare v3.21.2 in this PR: bump both Helm charts to 3.21.2 / appVersion: v3.21.2 and regenerate the Operator dependency lock, following release PR #573. This prepares the release; no version tag has been created or published.

Evidence

  • Before: main 347d671d produces RC.1 grants; current Ledger requires canonical names.
  • After: regression covers old-grant migration, exact values, unchanged credential UID/key ID/Secret, stale Ready rejection, observed-generation convergence and idempotent repeated reconciliation.
  • Release preparation: official Nix just pre-commit passed again after the chart bump, including strict Helm lint/template checks and dependency-lock regeneration.
  • Passed official Nix go test -race ./internal/resources/connectivities -count=1 and just pre-commit, with no generated drift.
  • Independent source review: Principal Engineer, Product Engineer and SRE pass for code; runtime grant application remains a deployment gate. Initial Nix disk-exhaustion failure was resolved and the official commands rerun successfully.

Merge Danger

Door: coordinated rollback.

Blast Radius: Stack-managed Connectivity.

This is a behavioral breaking change for Core versions still claiming RC.1 names. Upgrade Core and the Operator together against Ledger RC.2/RC.3; reverting only the desired grants can interrupt ingestion. No CRD/API or persisted-data migration is introduced, and no extra privilege is granted. David explicitly authorized an Operator breaking change in Codex on 2026-11-06; no merge was requested.

Kubernetes Credentials readiness confirms distribution, not that the Ledger Cluster controller applied registered-key grants. Verify actual scoped provisioning and ingestion after rollout. No deployment has occurred yet.

@NumaryBot NumaryBot added risk: medium NumaryBot classified this pull request as medium risk. bot-reviewed labels Nov 6, 2026
@NumaryBot NumaryBot added the draft-reviewed NumaryBot reviewed this draft, but published no readiness signal. label Nov 6, 2026
@Dav-14 Dav-14 changed the title fix(connectivities)!: EN-2807 align Ledger credential scopes fix(connectivities)!: EN-2807 prepare v3.21.2 with Ledger scope migration Nov 6, 2026
@NumaryBot NumaryBot added risk: high and removed risk: medium NumaryBot classified this pull request as medium risk. labels Nov 6, 2026
@Dav-14
Dav-14 marked this pull request as ready for review November 6, 2026 09:54
@Dav-14
Dav-14 requested a review from a team as a code owner November 6, 2026 09:54
@NumaryBot NumaryBot added review-approved The NumaryBot review gate is satisfied for the current head. and removed draft-reviewed NumaryBot reviewed this draft, but published no readiness signal. labels Nov 6, 2026

@NumaryBot NumaryBot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The required automated review completed with no remaining findings.

@Dav-14
Dav-14 merged commit 68a2995 into main Nov 6, 2026
17 checks passed
@Dav-14
Dav-14 deleted the codex/fix-connectivity-ledger-scopes-20261106 branch November 6, 2026 10:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bot-reviewed build-images review-approved The NumaryBot review gate is satisfied for the current head. risk: high

Development

Successfully merging this pull request may close these issues.

3 participants