Repository navigation
build(nix): use cached upstream Go in CI self-test flakes - #51
Merged
Merged
Conversation
NumaryBot
approved these changes
Oct 27, 2026
flemzord
marked this pull request as ready for review
October 27, 2026 14:33
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The root and standalone fixture shells import a Go compiler recipe into an older package set, which prevents reuse of the published compiler cache. Select upstream stable
go_1_27and its matchingbuildGo127Modulethrough a dedicatednixpkgs-goinput at1f607aa79b6356ed45d3cd3c8079c196e79efa2c(Go 1.27.3). Build the retained golangci-lint 2.15.0 recipe with that package set; stable's linter is only 2.12.2. KeepGOTOOLCHAIN=local.Every pre-existing lock node stays unchanged in both flakes. The fixture's Go 1.23.0 language minimum, source, Just recipes and self-test workflow are unchanged. No mockgen or additional compiler helpers exist in this repository. No documentation describes the removed workaround.
Validation
nix-instantiate --parse;nix flake metadata --no-write-lock-filesucceeds for both. Stable lock metadata exactly matches the verified input in dst #23 and the stable locked metadata in go-libs #720, following ledger #2391.Draft pending hosted qualification. No local Go executable is available, so fixture
just pre-commitandjust testswere not run. Full builds, lint, race/coverage suites and container setup were not run under the shared-host resource limit. The retained linter may still require its own build. CI has not been polled.Created with gpt-6.1-sol in T3 Code through the Codex harness.