Skip to content

Add the missing ExecutionMetadata.ExecutionMode values #3480

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
1fanwang wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Add the missing ExecutionMetadata.ExecutionMode values #3480

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e4c9445
Add the missing ExecutionMetadata.ExecutionMode values
1fanwang Oct 26, 2026
5a6b7b8
Merge current SDK base to keep execution-mode serialization compatible
1fanwang Nov 4, 2026
ecd29dc
Merge current SDK base with SafeDisk cache reads
1fanwang Nov 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions flytekit/models/execution.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,9 +41,13 @@ def from_flyte_idl(cls, pb2_object: flyteidl.admin.execution_pb2.SystemMetadata)

class ExecutionMetadata(_common_models.FlyteIdlEntity):
class ExecutionMode(object):
MANUAL = 0
SCHEDULED = 1
SYSTEM = 2
MANUAL = _execution_pb2.ExecutionMetadata.MANUAL
SCHEDULED = _execution_pb2.ExecutionMetadata.SCHEDULED
SYSTEM = _execution_pb2.ExecutionMetadata.SYSTEM
RELAUNCH = _execution_pb2.ExecutionMetadata.RELAUNCH
CHILD_WORKFLOW = _execution_pb2.ExecutionMetadata.CHILD_WORKFLOW
RECOVERED = _execution_pb2.ExecutionMetadata.RECOVERED
TRIGGER = _execution_pb2.ExecutionMetadata.TRIGGER

def __init__(
self,
Expand Down
6 changes: 6 additions & 0 deletions tests/flytekit/unit/models/test_execution.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@
from datetime import timezone

import pytest
from flyteidl.admin import execution_pb2 as _execution_pb2

from flytekit.models import common as _common_models
from flytekit.models import execution as _execution
Expand Down Expand Up @@ -149,6 +150,11 @@ def test_execution_metadata():
assert obj2.system_metadata == system_metadata


@pytest.mark.parametrize("name, value", _execution_pb2.ExecutionMetadata.ExecutionMode.items())
def test_execution_mode_matches_idl(name: str, value: int) -> None:
assert getattr(_execution.ExecutionMetadata.ExecutionMode, name) == value


@pytest.mark.parametrize("literal_value_pair", _parameterizers.LIST_OF_SCALAR_LITERALS_AND_PYTHON_VALUE)
def test_execution_spec(literal_value_pair):
literal_value, _ = literal_value_pair
Expand Down
Loading