You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Fix HEX editing, picker gestures, and wheel rendering - #117
nohli
changed the title
Fix picker state, input coordinates, and example portability
Fix HEX editing, picker gestures, and wheel rendering
Oct 11, 2026
The reason will be displayed to describe this comment to others. Learn more.
🔵 Needs a closer look
Two critical active issues block verification: both CI jobs cannot resolve the Flutter SDK dependency with standalone Dart, and the new test contains null-safety errors that prevent analysis.
No open issues 🎉
2 previously missed issues
In code that hasn't changed since last review
Use Flutter to resolve the root package dependencies
.github/workflows/flutter_checks.yml:28
The root package declares flutter as an SDK dependency, but this invokes the standalone Dart package tool. dart pub get cannot resolve sdk: flutter in a Flutter package, so both matrix jobs fail before analysis and tests run. Use the Flutter wrapper here (for example, flutter pub get --no-example) instead.
Assert the nullable test result before indexing bytes
test/wheel_rendering_test.dart:34
tester.runAsync returns a nullable result, and the non-null assertion on line 31 does not promote the bytes variable for later expressions. These three indexed accesses therefore fail null-safety analysis; assert once when assigning the result (or retain ! on every access) before running the new test suite.
Two critical active issues block verification: both CI jobs cannot resolve the Flutter SDK dependency with standalone Dart, and the new test contains null-safety errors that prevent analysis.
No open issues 🎉
2 previously missed issues
In code that hasn't changed since last review
Use Flutter to resolve the root package dependencies Assert the nullable test result before indexing bytes
Review effort: Lite
Both findings are false positives on the reviewed commit, b6227c8:
Dependency resolution: The workflow installs Flutter before running dart pub get --no-example. That exact command succeeds on both Flutter 3.10.6 and stable; neither job fails at dependency resolution.
Nullable test result: The assertion in bytes![0] promotes the local bytes variable to non-nullable for subsequent accesses. The later bytes[1], bytes[2], and bytes[3] expressions are valid. Analysis and tests pass on both Flutter versions.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've fixed the picker interactions and example issues for
1.6.0.Changes
The package keeps its Flutter 2.10 minimum. The native example requires Flutter 3.47+.
Testing