fix: stop requiring CKAN_DATAPUSHER_URL in entrypoint - #93
Merged
Conversation
fjelltopp-ansible removed CKAN_DATAPUSHER_URL from the ckan Deployment env (fix: remove datapusher, #79) back on 2026-07-10, but this entrypoint still hard-aborted without it. Since neither dev nor prod had been redeployed since, the incompatibility stayed dormant until the next rollout hit it — surfaced as a crash loop deploying an unrelated fix (fjelltopp/fjelltopp-ansible#85). Datapusher itself was already disabled in all envs, so the check is simply removed rather than replaced.
There was a problem hiding this comment.
Pull request overview
This pull request updates the CKAN container entrypoint to stop hard-failing startup when CKAN_DATAPUSHER_URL is not set, aligning runtime expectations with deployments where datapusher has been removed/disabled.
Changes:
- Removes the startup abort that required
CKAN_DATAPUSHER_URLto be set. - Updates the inline comment to reflect that datapusher is optional in current environments.
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ckan-entrypoint.shhas hard-aborted startup withoutCKAN_DATAPUSHER_URLsince 2021.fjelltopp-ansiblestopped setting that env var on 2026-07-10 (fix: remove datapusher, fjelltopp/fjelltopp-ansible#79) since datapusher is disabled in all envs — but nothing here was updated to match, so the entrypoint's requirement became stale.This stayed dormant because neither
dms-devnordms-prodhad been redeployed since 2026-07-10. It surfaced today as an immediate crash loop (ERROR: no CKAN_DATAPUSHER_URL specified in docker-compose.yml) while rolling out an unrelated fix (fjelltopp/fjelltopp-ansible#85) — the first deploy to touch either environment since the var was removed.Change
Removes the
CKAN_DATAPUSHER_URLabort check. Datapusher is already gone from the deployment env everywhere, so the check is deleted rather than reworked.Test plan
dms-staging:<sha>imagedms_dev'sckan_image_tagat that sha in dms-infrastructure, redeploy, confirm the pod starts cleanlydms:<tag>picks up the fix for prod