Skip to content

chore: remove Jenkins pipeline files and bump GHA actions - #92

Merged
ChasNelson1990 merged 5 commits into
masterfrom
chore/remove-jenkins
Jun 26, 2026
Merged

chore: remove Jenkins pipeline files and bump GHA actions#92
ChasNelson1990 merged 5 commits into
masterfrom
chore/remove-jenkins

Conversation

@ChasNelson1990

@ChasNelson1990 ChasNelson1990 commented Jun 26, 2026

Copy link
Copy Markdown
Member

Summary

Jenkins has been replaced by GitHub Actions for image builds. This PR removes the legacy Jenkins files from the dms repo and updates the GitHub Actions workflow to use Node.js 24 compatible action versions.

Changes

  • Remove jenkins/ directory — contained Jenkinsfile.build.groovy (built images to ECR) and dsl.groovy (Jenkins Job DSL defining the DMS-build and DMS-deploy jobs). Both are superseded by .github/workflows/build.yml which builds to GHCR.
  • Bump GitHub Actions in build.yml:
    • actions/checkout v3→v7
    • docker/setup-buildx-action v2→v4
    • docker/login-action v2→v4
    • docker/build-push-action v4→v7
    • Node.js 20 is deprecated on GHA runners (forced to Node.js 24 from June 2026)
  • Remove docker/metadata-action step — it was unused (no later step referenced steps.meta.outputs.*), so it was dropped rather than bumped.

Test plan

  • Push a commit to masterbuild.yml should run and push a staging image to ghcr.io/fjelltopp/dms-staging without Node.js deprecation warnings
  • Push a git tag — build.yml should push a release image to ghcr.io/fjelltopp/dms:<tag>

🤖 Generated with Claude Code

ChasNelson1990 and others added 2 commits June 26, 2026 16:10
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
actions/checkout v3→v7, docker actions v2/v4→latest

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR completes the migration away from Jenkins by removing legacy Jenkins pipeline/job definitions and updating the GitHub Actions Docker build workflow to newer action versions intended to be compatible with the runner Node.js upgrade.

Changes:

  • Removed the legacy jenkins/ pipeline and Job DSL files.
  • Bumped GitHub Actions used by the Docker build workflow to newer major versions.
  • Kept the existing branching/tagging behavior for staging vs release image pushes.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.

File Description
jenkins/Jenkinsfile.build.groovy Removed legacy Jenkins pipeline used for ECR image builds.
jenkins/dsl.groovy Removed Jenkins Job DSL definitions for build/deploy jobs.
.github/workflows/build.yml Updated action versions for checkout and Docker build/push steps.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread .github/workflows/build.yml Outdated
Comment thread .github/workflows/build.yml Outdated
Comment thread .github/workflows/build.yml Outdated

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

Comment thread .github/workflows/build.yml

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated no new comments.

@ChasNelson1990
ChasNelson1990 merged commit 587e08b into master Jun 26, 2026
2 checks passed
@ChasNelson1990
ChasNelson1990 deleted the chore/remove-jenkins branch June 26, 2026 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants