fix(auth)!: remove non-functional MFA recovery codes - #2457
Open
demolaf wants to merge 1 commit into
Open
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request removes the recovery (backup) codes feature from the Multi-Factor Authentication (MFA) enrollment flow across FirebaseUI Auth, as Firebase Authentication lacks a backup-code primitive to verify them at sign-in. The changes include removing the enableRecoveryCodes configuration option, deleting the ShowRecoveryCodes step and its associated UI components, removing localized string resources for recovery codes across all supported languages, and updating the documentation and tests accordingly. I have no feedback to provide as there are no review comments to assess.
demolaf
force-pushed
the
fix/remove-unverifiable-mfa-recovery-codes
branch
from
August 26, 2026 15:35
237b403 to
2e4f64c
Compare
demolaf
force-pushed
the
fix/remove-unverifiable-mfa-recovery-codes
branch
from
August 26, 2026 17:48
2e4f64c to
9504a08
Compare
demolaf
marked this pull request as ready for review
August 26, 2026 18:06
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes the MFA recovery-codes API surface. Pre-GA (
10.0.0-beta05), so no deprecation cycle.AuthUIStringProvider—recoveryCodesSavedAction,mfaStepShowRecoveryCodesTitleandmfaStepShowRecoveryCodesHelperare gone from the public interface. Anyone with a customAuthUIStringProviderimplementation will fail to compile ('recoveryCodesSavedAction' is not a member of supertype) until those overrides are deleted.MfaConfiguration.enableRecoveryCodes— constructor parameter removed. It previously defaulted totrue, so callers who never set it are unaffected at the source level; callers who passed it explicitly must drop the argument.MfaEnrollmentStep.ShowRecoveryCodes— enum case removed. Any exhaustivewhenoverMfaEnrollmentStepin a custom enrollment slot must drop that branch.MfaEnrollmentContentState.recoveryCodes/.onCodesSavedClick— removed.fui_recovery_codes_saved_action,fui_mfa_step_show_recovery_codes_titleandfui_mfa_step_show_recovery_codes_helperremoved across all 85 locales.Behaviour change: with recovery codes enabled (the previous default),
onCompletefired when the user confirmed they had saved their codes. It now fires as soon as the second factor is verified — one interaction earlier.Maintainer note: Fixes internal CPRN-379