Skip to content

Code Quality: Moved location catalogs and live notifications to the server - #19078

Merged
yair100 merged 14 commits into
files-community:mainfrom
hez2010:server-catalog-services
Nov 1, 2026
Merged

yair100 merged 14 commits into
files-community:mainfrom
hez2010:server-catalog-services

Conversation

@hez2010

@hez2010 hez2010 commented Oct 28, 2026 •

Copy link
Copy Markdown
Member

Moved locations, recycle bin, jump list, watchers to the server

This also addresses a couple of issues like folder icon not loading sometimes due to GDI+ not initialized, improves server session mamagement, and allows apps to spawn a new server if the old died.

Depends on #19070 and #19077

Resolved / Related Issues

To prevent extra work, all changes to the Files codebase must link to an approved issue marked as Ready to build. Please insert the issue number following the hashtag with the issue number that this Pull Request resolves.

  • Closes #

Steps used to test these changes

Stability is a top priority for Files and all changes are required to go through testing before being merged into the repo. Please include a list of steps that you used to test this PR.

  1. Opened Files ...
  2. ...

@hez2010
hez2010 force-pushed the server-catalog-services branch 4 times, most recently from 45b9740 to bfe8207 Compare October 28, 2026 23:42
@hez2010 hez2010 changed the title Features: Moved location catalogs and live notifications to the server Feature: Moved location catalogs and live notifications to the server Oct 29, 2026
@hez2010
hez2010 force-pushed the server-catalog-services branch from 893db95 to 8d69142 Compare October 29, 2026 20:06
@hez2010
hez2010 marked this pull request as ready for review October 29, 2026 20:06
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 29, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ⚠️ Failed 2026-10-29T20:07:07.950086Z
We couldn’t complete this review. Comment @codex review to try again.
8d69142 Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

Comment thread src/Files.App.Server/ServerEvents.cs Resolved
@yair100 yair100 added the ready for review Pull requests that are ready for review label Oct 29, 2026
@hez2010

hez2010 commented Oct 30, 2026 •

Copy link
Copy Markdown
Member Author

@yair100 PTAL.

@yair100 yair100 added ready to merge Pull requests that are approved and ready to merge and removed ready for review Pull requests that are ready for review labels Nov 1, 2026
@yair100 yair100 changed the title Feature: Moved location catalogs and live notifications to the server Code Quality: Moved location catalogs and live notifications to the server Nov 1, 2026
@yair100

yair100 commented Nov 1, 2026

Copy link
Copy Markdown
Member

Thank you

@yair100
yair100 merged commit 9f55197 into files-community:main Nov 1, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready to merge Pull requests that are approved and ready to merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants